Disk space issues and log rotation. (OpenWRT)

[mercyground]

Prerequisites

Please answer the following questions for yourself before submitting an issue. YOU MAY DELETE THE PREREQUISITES SECTION.

• [X ] I am running the latest version
• [X ] I checked the documentation and found no answer
• [X ] I checked to make sure that this issue has not already been filed

Issue Details

• Version of AdGuard Home server:

  • Updating from v0.107.0-a.198+1e729601 to v0.107.0-a.199+2fc10848.

• How did you install AdGuard Home:

  • Originally installed via AGH script. Edge build

• If it's a router or IoT, please write device model:

  • BT Home Hub 5

• CPU architecture:

  • (MIPS)

• Operating system and version:

  • ( OpenWrt 21.02.0, r16279-5cc0535800)

Expected Behavior

Currently AGH copies its binary and config to the /opt/AdGuardHome/agh-backup folder on upgrade. However it does not appear to check for available diskspace before it does so and thus on limited space filesystems AGH fails the upgrade and does not report reason why on the control panel (however it does report on the router logs). A error message back to the web console would be appreciated.

Also AGH recently changed how it managed logs/query logging but there is no way to have it purge the old logs at the rotation leading to double the disk space needed?
1e72960

At present i manage these issues by manually deleting the rotated logs and purging the backed up copy of AGH once it has updated to stop AGH running out of disk space. A method for managing this or even a warning to the console that disk space is low would be a good addition.

[ainar-g]

Thank you for your report! The error message should definitely be added / improved. As for the log rotation and doubling, #3404 should allow you to simply set a lower custom value for log rotation.

[mercyground]

As part of the upgrade a simple disk space check should be done maybe?

So you click the upgrade and it checks to see if there is space and warns you to fix the issue rather than a failed upgrade would be a better experience.

The logging space issues can be managed by just keeping shorter logs on OpenWRT or limited space devices.

[ainar-g]

Okay, so after some researching, I'm not sure that we'll be able to do this properly in the v0.107 cycle. In order to know if there is enough disk space, we'll need to get the data about the compressed and uncompressed size of the release, and that information is currently unavailable to us.

Besides, our update procedure just generally needs a refactoring, and that's supposed to happen in the v0.108 cycle, see #2630.