Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When adding a filter, show how many rules are applicable to DNS filtering rather than the total rules #4818

Open
3 tasks done
ghost opened this issue Aug 7, 2022 · 0 comments

Comments

@ghost
Copy link

ghost commented Aug 7, 2022

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

What problem are you trying to solve?

When adding a DNS filtering list to AdGuard Home it shows how many rules are contained within the filter list. The total amount of rules does not indicate whether they are suitable for DNS filtering, thus an entire filtering list could be pointlessly added.

Proposed solution

Add checks against added filters to determine the effectiveness of the filter by counting how many DNS applicable rules there are.

Additional information

Below is an example list that shows the total number of rules, but from what I've observed there doesn't appear to be many (if any) rules that are applicable to DNS filtering.
https://raw.githubusercontent.com/uBlockOrigin/uAssets/master/filters/quick-fixes.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant