Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider custom port in Dockerfile healthcheck #5645

Closed
3 tasks done
EugeneOne1 opened this issue Mar 28, 2023 · 1 comment
Closed
3 tasks done

Consider custom port in Dockerfile healthcheck #5645

EugeneOne1 opened this issue Mar 28, 2023 · 1 comment
Assignees
Labels
Milestone

Comments

@EugeneOne1
Copy link
Member

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to request a feature or enhancement and not ask a question

Description

In #3290 we've implemented the Docker-provided healthcheck. Currently it supports parsing the configuration file, fetching the root endpoint of web UI, and requesting DNS. It also detects if AdGuard Home isn't yet configured and tries to reach the installation endpoint in this case.

Though, the official Dockerfile intends using port 3000 for installation web UI endpoint, there is a use case where user can specify some custom port via command-line options. Note also, that custom port can be specified after installation as well. Both these cases should be covered.

@EugeneOne1 EugeneOne1 self-assigned this Mar 28, 2023
@ainar-g ainar-g added P4: Low docker Docker-related issues labels Mar 28, 2023
@ainar-g ainar-g added this to the v0.107.27 milestone Mar 28, 2023
@EugeneOne1
Copy link
Member Author

As of v0.108.0-a.603+f7dd8325, AdGuard Home no longer supports the Dockerfile healthcheck mechanism, so this issue doesn't seem to be relevant.

@EugeneOne1 EugeneOne1 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 21, 2023
@EugeneOne1 EugeneOne1 added wontfix and removed enhancement P4: Low docker Docker-related issues labels Aug 21, 2023
@ainar-g ainar-g modified the milestones: v0.107.38, v0.107.37 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants