Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client specific with regex does not work #5650

Closed
3 tasks done
ghahramani opened this issue Mar 29, 2023 · 6 comments
Closed
3 tasks done

Client specific with regex does not work #5650

ghahramani opened this issue Mar 29, 2023 · 6 comments
Labels
duplicate Duplicate or merged issues.

Comments

@ghahramani
Copy link

Prerequisites

  • I have checked the Wiki and Discussions and found no answer

  • I have searched other issues and found no duplicates

  • I want to report a bug and not ask a question

Operating system type

Linux, OpenWrt

CPU architecture

64-bit ARM

Installation

GitHub releases or script from README

Setup

On a router, DHCP is handled by the router

AdGuard Home version

v0.107.21

Description

Hi,

I have added the simple custom query to my adguard in my openwrt router and also specified the client in the panel with mac address but the filter does not work when I specify the client in regex filter rules

/.*youtube.*/$client=Playstation

It works perfectly when I use

/.*youtube.*/

Expected result

Should filter youtube only in Playstation client which is added by mac address

Actual result

Does not filter unless I remove the $client

@ainar-g
Copy link
Contributor

ainar-g commented Mar 29, 2023

Hello. Unfortunately, I cannot reproduce this. Some possible solutions:

  1. Please make sure you're using the client name as opposed to ClientID in the modifier.

  2. v0.107.21 is not the most recent release of AdGuard Home, so try updating.

@ainar-g ainar-g added the waiting for data Waiting for users to provide more data. label Mar 29, 2023
@ghahramani
Copy link
Author

Hi,

  1. I am using the client name, I have attached the screenshot shot
  2. There is no update for openwrt, please see the attached screenshot

Screenshot_2023-03-30-10-20-36-21_e4424258c8b8649f6e67d283a50a2cbc~3
Screenshot_2023-03-30-10-17-53-01_e4424258c8b8649f6e67d283a50a2cbc~2

@ainar-g
Copy link
Contributor

ainar-g commented Mar 30, 2023

I am using the client name, I have attached the screenshot shot

Are you using an IP address to identify the Playstation client, a MAC, or both? MAC identification only works if AdGuard Home is the DHCP server, which you indicated that it's not. If the Playstation client has a static IP, I'd recommend using that.

There is no update for openwrt, please see the attached screenshot

You have indicated that you've used the official installation method as opposed to an OS package. I assume that that was incorrect? The latest released version is v0.107.26.

@ghahramani
Copy link
Author

I used the package manager of openwrt, sorry if I selected it wrong, yes I am only using mac address only, no ip address. I will update it to use ip address and will let you know but it would be great if I could use it with mac address even if it is not dhcp server and the reason is I have ipv6 as well and it is hard to match with that as well as it comes from my isp.

@ghahramani
Copy link
Author

Ok, it seems it works with IP address and I used the exclude expression (~) but it is a bit hard as I used ipv6 as well and each device has multiple ones which makes it hard to just add each devices ipv4 and ipv6

@ainar-g
Copy link
Contributor

ainar-g commented Apr 19, 2023

Apologies for the late response. As mentioned, MAC addresses currently only work when AdGuard Home works as the network's DHCP server. The issue about expanding that is #961. You can add multiple IP addresses to each persistent client's identifier list, and if your devices support encrypted protocols, you could also use ClientIDs.

I'll close this issue, as the basic problem is the same as in 961, if you don't mind.

@ainar-g ainar-g closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2023
@ainar-g ainar-g added duplicate Duplicate or merged issues. and removed waiting for data Waiting for users to provide more data. labels Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate Duplicate or merged issues.
Projects
None yet
Development

No branches or pull requests

2 participants