Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: malformed entry when making NS . queries #5910

Closed
4 tasks done
ainar-g opened this issue Jun 16, 2023 · 2 comments
Closed
4 tasks done

stats: malformed entry when making NS . queries #5910

ainar-g opened this issue Jun 16, 2023 · 2 comments
Assignees
Milestone

Comments

@ainar-g
Copy link
Contributor

ainar-g commented Jun 16, 2023

Prerequisites

Platform (OS and CPU architecture)

Linux/AMD64 (aka x86_64)

Installation

GitHub releases or script from README

Setup

On one machine

AdGuard Home version

v0.108.0-a.567+d3ada988

Action

  1. dig IN NS .
  2. Inspect the verbose logs.

Expected result

No errors, the query is recorded in the statistics.

Actual result

[debug] stats: malformed entry

Additional information and/or screenshots

It looks like Update receives an Entry with an empty domain name in this case, which makes it think that the domain name has always been empty, and that the entry is invalid. We should see if we can not trimming the domain name here and leave it to be . for such queries.

@ainar-g
Copy link
Contributor Author

ainar-g commented Jun 16, 2023

This also concerns the query log, where the query looks rather weird as well.

@Mizzick
Copy link
Contributor

Mizzick commented Jun 21, 2023

Please have a look, we have implemented the requested changes.
The new build v0.108.0-a.572+ca313521 has been published to the edge channel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants