New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

) #1245

Closed
ghost opened this Issue Aug 22, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@ghost

ghost commented Aug 22, 2016

No description provided.

@ameshkov ameshkov added this to the 6.1 R2 milestone Aug 22, 2016

@ameshkov ameshkov added the bug label Aug 22, 2016

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 22, 2016

Member

Hm, for some reason "iframe" elements are not removed from the page code.

As I recall we do this because of the possible issues with the "frameset" elements.
The question is: why do we do this for all "iframe" elements while we could easily check if there is a frameset or not.

Member

ameshkov commented Aug 22, 2016

Hm, for some reason "iframe" elements are not removed from the page code.

As I recall we do this because of the possible issues with the "frameset" elements.
The question is: why do we do this for all "iframe" elements while we could easily check if there is a frameset or not.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Aug 29, 2016

Member

What exactly is not possible?

Member

ameshkov commented Aug 29, 2016

What exactly is not possible?

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Sep 6, 2016

Member

It is pretty easy to remove iframes and as I recall we were doing it in previous versions.

It's a pity we didn't use github before as I don't remember why we had stopped doing it.

@suhan3z I suggest setting "style" attribute to "display:none!important;" instead of simply removing "frame" and "iframe" elements.

Member

ameshkov commented Sep 6, 2016

It is pretty easy to remove iframes and as I recall we were doing it in previous versions.

It's a pity we didn't use github before as I don't remember why we had stopped doing it.

@suhan3z I suggest setting "style" attribute to "display:none!important;" instead of simply removing "frame" and "iframe" elements.

@ameshkov

This comment has been minimized.

Show comment
Hide comment
@ameshkov

ameshkov Sep 7, 2016

Member

you mean 'in addition to' (emphasis on the bold)

In fact i suppose that using it instead is valid too as anyway when "display: none" is applied all other styles are ignored.

Member

ameshkov commented Sep 7, 2016

you mean 'in addition to' (emphasis on the bold)

In fact i suppose that using it instead is valid too as anyway when "display: none" is applied all other styles are ignored.

@ameshkov ameshkov assigned adbuker and unassigned suhan3z Sep 29, 2016

@adbuker adbuker closed this Oct 11, 2016

@ghost ghost changed the title from Blocked network requests are not collapsed to ) Apr 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment