Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version check algorithm for filters added by URL #1431

Closed
vbagirov opened this issue Dec 5, 2016 · 3 comments
Closed

Version check algorithm for filters added by URL #1431

vbagirov opened this issue Dec 5, 2016 · 3 comments
Assignees
@adbuker
Labels
UI
Milestone
6.2

Comments

@vbagirov
Copy link
Member

vbagirov commented Dec 5, 2016

When a filter is added by URL and the update check is performed, compare the current filter version and server version as two strings. If they coincide, display 'No updates found' in the changelog window.
@vbagirov vbagirov added the UI label Dec 5, 2016
@vbagirov vbagirov added this to the 6.2 milestone Dec 5, 2016
@ameshkov
Copy link
Member

ameshkov commented Dec 5, 2016

This really makes sense. There is a ! Version: attribute there we can use.

@Bluscream
Copy link

This isn't already a thing? :o

@confessor-adguard confessor-adguard mentioned this issue Mar 13, 2017
Closed
@adbuker adbuker assigned adbuker and unassigned suhan3z Jun 28, 2017
@adbuker
Copy link

adbuker commented Jun 28, 2017

resolved in ADWIN-CR-223

@adbuker adbuker closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adbuker adbuker

Labels
UI
Projects
None yet
Milestone
6.2
Development

No branches or pull requests
5 participants
@Bluscream @suhan3z @ameshkov @vbagirov @adbuker