Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase range of the $$ rules #1464

Closed
vbagirov opened this issue Dec 29, 2016 · 5 comments
Closed

Increase range of the $$ rules #1464

vbagirov opened this issue Dec 29, 2016 · 5 comments
Assignees
Milestone

Comments

@vbagirov
Copy link
Member

"Sometimes webmasters implement a very long script with junk, just to avoid $$ rules.

http://imgclick.net/u/gqztmmrwg44a is one of those examples. Even when setting the max value of 32768 is not removing the script when given."

Original thread:
https://forum.adguard.com/index.php?threads/increase-range-of-rules.18224/

@vbagirov vbagirov added this to the 6.2 milestone Dec 29, 2016
@ameshkov ameshkov removed this from the 6.2 milestone Jan 1, 2017
@ameshkov
Copy link
Member

ameshkov commented Jan 1, 2017

We should first discuss it. I am not sure we should change the 32KB limit right away as it will affect the whole parsing process.

@ameshkov ameshkov added this to the 6.2 milestone Jan 2, 2017
@ameshkov
Copy link
Member

ameshkov commented Jan 2, 2017

Ok, I think I know what to do. The easiest solution would be to remove this limitation for script and style tags only.

@ameshkov
Copy link
Member

ameshkov commented Feb 9, 2017

Also, we should make sure, that we don't cut elements, which are partly sent to the client already.

@ameshkov ameshkov changed the title [Feature request] Increase range of $$ rules Increase range of the $$ rules Feb 9, 2017
@ameshkov ameshkov assigned adbuker and unassigned confessor-adguard Feb 9, 2017
@adbuker
Copy link

adbuker commented Mar 24, 2017

that we don't cut elements, which are partly sent to the client already

@ameshkov, I suggest, that this case is impossible in fact because we write element (regardless of whether it was edited or not) only after processed it, including finding ranges to remove.

@ameshkov
Copy link
Member

@adbuker elements might be nested (div inside of a div for instance). Shouldn't be a problem for script and style tags, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants