Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the trimming limit we use for request URLs #1820

Closed
ameshkov opened this issue Jul 4, 2017 · 1 comment
Closed

Increase the trimming limit we use for request URLs #1820

ameshkov opened this issue Jul 4, 2017 · 1 comment
Assignees
@adbuker
Labels
ad blocking
Milestone
6.2

Comments

@ameshkov
Copy link
Member

ameshkov commented Jul 4, 2017

We currently trim URLs to the length of 1024 in order to speed up matching and avoid issues with ridiculously long URLs.

As @seanl-adg points out, 1024 is not enough.

Let's increase it to 4KB.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adbuker adbuker

Labels
ad blocking
Projects
None yet
Milestone
6.2
Development

No branches or pull requests
2 participants
@ameshkov @adbuker