Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle runtime ff-certificate issues #2390

Closed
adbuker opened this issue Dec 13, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@adbuker
Copy link

commented Dec 13, 2018

  1. CL should notify us about unknown_ca alerts from browsers.
  2. If this is a Firefox-based browser (Firefox, Cyberfox, Cliqz, Tor, etc), then you should check if our cert is allowed.
  3. If our cert is not allowed, notify the user that there's an issue, and offer to reinstall certificate.

@adbuker adbuker added the network label Dec 13, 2018

@adbuker adbuker added this to the 7.0 milestone Dec 13, 2018

@adbuker adbuker self-assigned this Dec 13, 2018

@adbuker

This comment has been minimized.

Copy link
Author

commented Dec 19, 2018

Also within this issue, we should properly handle certificate installation error codes

@adbuker adbuker changed the title Add UI-related procedure for asking the firefox password Handle certificate installation error codes (including UI-related procedure for asking the firefox password) Dec 20, 2018

@adbuker adbuker changed the title Handle certificate installation error codes (including UI-related procedure for asking the firefox password) Handle runtime ff-certificate issues Dec 29, 2018

@ameshkov

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@adbuker also check what's wrong with FF beta, nightly and dev. AG seems to ignore them and not add cert

@adbuker

This comment has been minimized.

Copy link
Author

commented Apr 26, 2019

How to test:
Case 1:

  1. Disable filtering the sites with EV certs
  2. Go to github.com
  3. Check, that page is not filtered, and notification about suggesting to add to EV filter list appears and appears only once (even if you go to sub-pages of the gihub.com)
  4. Enable filtering the sites with EV certs
  5. Go to the github.com
  6. Check, that page is filtered
  7. Repeat steps 1-3

Case 2

  1. Disable filtering the sites with EV certs
  2. Clean the list of EV exclusions
  3. Go to github.com
  4. Check, that page is not filtered, and notification about suggesting to add to EV filter list appears and appears only once (even if you go to sub-pages of the gihub.com)
  5. Add github.com to the list of EV exclusions
  6. Go to the github.com
  7. Check, that page is filtered
  8. Repeat steps 2-4

Case 3

  1. Start AG4W
  2. Open Firefox browser
  3. Go to any page and wait for "Unknown CA" page will appear (ping me if an error not appears) and appears only once (even if you go any other pages)
  4. Check, that notification about suggesting to reinstall CA certificate appears
  5. Click notification, and then "Yes" on the confirmation dialog
  6. Check, that FF browser will be closed
  7. Open FF browser and check, that pages open normally, without "Unknow CA" errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.