Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom filters always look like they were updated #2501

Closed
Alex-302 opened this issue Mar 12, 2019 · 3 comments
Closed

Custom filters always look like they were updated #2501

Alex-302 opened this issue Mar 12, 2019 · 3 comments
Assignees
@northis
Labels
bug P3: Medium
Milestone
7.0

Comments

@Alex-302
Copy link
Member

Steps to reproduce

  1. Import custom filter by URL (https://gist.github.com/ is in my case)
  2. Check for updates

Expected behavior

Custom filter is up to date

Actual behavior

The filter is downloaded at every check.

image

Your environment

AdGuard 7.0.2286.5847
@ameshkov ameshkov changed the title Custom filter is always fresh Custom filters always look like they were updated Mar 12, 2019
@ameshkov ameshkov added this to the 7.0 milestone Mar 12, 2019
@ameshkov
Copy link
Member

We should check if the filter's content was changed

@northis
Copy link
Member

northis commented Apr 12, 2019

Resolved in adguard-windows/pull-requests/385

@northis
Copy link
Member

northis commented Apr 12, 2019

For test use the filter that doesn't have version - it this case file contents comparing will be applied.

@zzebrum zzebrum closed this as completed May 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@northis northis

Labels
bug P3: Medium
Projects
None yet
Milestone
7.0
Development

No branches or pull requests
4 participants
@ameshkov @Alex-302 @northis @zzebrum