Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior of the first rule in User Rules filter. #4885

Closed
KolbasovAnton opened this issue Nov 1, 2023 · 0 comments
Closed

Incorrect behavior of the first rule in User Rules filter. #4885

KolbasovAnton opened this issue Nov 1, 2023 · 0 comments

Comments

@KolbasovAnton
Copy link

KolbasovAnton commented Nov 1, 2023

AdGuard version

7.15.1 (4386)

Browser version

Chrome 119.0.6045.106

OS version

Windows 11, 10.0.22621 build 22621

What filters do you have enabled?

No response

What Stealth Mode options do you have enabled?

No response

Support ticket ID

No response

Issue Details

STR:

  1. Run latest version of AG (7.15.1).
  2. Ad Blocker - Filter editor.
  3. "User rules" filter selected by default.
  4. Click "Open advanced filter editor" (pen icon).
  5. Advanced editor opens.
  6. Close advanced editor and add some (4-5) rules to "User rules" filter (add rules by pressing "Enter").
  7. Disable all rules with right mouse button.
  8. Select any other filter (AG Base filter or language filter).
  9. Go back to "User rules" filter.
  10. Enable all rules with right mouse button.
  11. Disable and enable back all rules by un-checking them.
  12. Delete first rule in list and repeat steps 7 - 11.

AR:
4 - Floating bug - Instead of one string there's already two of them and focus is on the second, not the first one.
6 - Passing to the next rule string with "Enter" focuses You on previous string instead of current.
7 - Disabled with RMB, first rule is un-checking only after clicking on another filter.
9 - Floating bug - Number of rules in filter info can change during all this manipulations.
10 - First rule can be enabled only through checking it back, RMB doesn't work.

Expected Behavior

4 - At first opening, Advanced editor consist only one string.
6 - Passing to the next rule string with "Enter" when adding rules, focuses You on current string.
7 - Disabled with RMB, rule is un-checking immediately.
9 - Number of rules in filter info shows overall count of added rules, no matter enabled or disabled.
10 - Enabled with RMB, rule is checking back immediately.

Screenshots

TC298001.mp4

Additional Information

adg_logs_7.15.4386.0_1101_1122.zip

Bug recorded at 11:15 - 11:17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants