Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website can be broken because of invalid HTML inside a "noscript" tag #960

Closed
Alex-302 opened this issue Mar 14, 2016 · 5 comments
Closed

Website can be broken because of invalid HTML inside a "noscript" tag #960

Alex-302 opened this issue Mar 14, 2016 · 5 comments
Assignees
@ameshkov
Labels
ad blocking bug
Milestone
6.0 R2

Comments

@Alex-302
Copy link
Member

![](http://imagizer.imageshack.com/img921/5020/mrrpTB.jpg)
Compe normal and broken html:
![](http://ipic.su/img/img7/fs/kiss_35kb.1457773760.png)
Caused by rule from English filter: 
||smartadserver.com^$third-party

Maybe because tag is not closed.
@Alex-302 Alex-302 added this to the 6.1 milestone Mar 14, 2016
@ameshkov ameshkov modified the milestones: 6.0 R2, 6.1 Mar 15, 2016
@ameshkov
Copy link
Member

Seems to be caused by #907 issue.

@Vincent-Michael Vincent-Michael mentioned this issue Mar 16, 2016
Closed
@Alex-302
Copy link
Member Author

temporary added to German filter:
@@||gofeminin.de^$content

@ameshkov
Copy link
Member

The problem is caused by invalid html attribute alt which equals to one quote.

<img src="http://ww251.smartadserver.com/ac?out=nonrich&nwid=251&siteid=75630&pgname=&fmtid=3651&visit=m&tmstp=1459173449" border="0" alt=" />

So, AG parses this HTML element until the next quote.

@ameshkov
Copy link
Member

The only thing I suggest is to skip noscript tag like we do with script and style.

@ameshkov ameshkov changed the title gofeminin.de is broken by content filtering Website can be broken by invalid HTML inside a "noscript" tag Mar 28, 2016
@ameshkov ameshkov changed the title Website can be broken by invalid HTML inside a "noscript" tag Website can be broken because of invalid HTML inside a "noscript" tag Mar 28, 2016
@ameshkov
Copy link
Member

Fixed

This was referenced Mar 28, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ameshkov ameshkov

Labels
ad blocking bug
Projects
None yet
Milestone
6.0 R2
Development

No branches or pull requests
2 participants
@ameshkov @Alex-302