Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser Assistant popup is not properly updated in a specific case (on Edge at least) #59

Closed
contribucious opened this issue Feb 15, 2022 · 1 comment

Comments

@contribucious
Copy link

Hello,

Here is a new issue, with the aim of always improving AdGuard.

⚙️ Requirement

  • A browser that keeps the extension popup open when clicking outside the main window (Edge: OK, any Chromium-based browser: probably, Firefox: not the case).

ℹ️ My environment

  • AdGuard Browser Assistant 1.3.2 (latest stable, installed from Chrome Web Store) on Edge 98.0.1108.50 (latest stable)
    • Same result with the latest beta installed from Chrome Web Store (which is v1.3.2).
  • AdGuard 7.8 on Windows 10 Pro 21H2 (OS Build 19044.1526)

Thanks in advance! 🙂


 

Compare these two reproducible situations (only the order of the first two actions changes).

Situation 1 ✔️

  1. Open the AdGuard Browser Assistant popup
  2. Disable protection in AdGuard itself (via main UI or systray icon)
  3. Re-enable protection in AdGuard itself (via main UI or systray icon) ➡️ popup content is correct, showing "Protection is enabled"

🎥 See video 1 (31 sec.)
 

Situation 2 ✖️

  1. Disable protection in AdGuard itself (via main UI or systray icon)
  2. Open the AdGuard Browser Assistant popup
  3. Re-enable protection in AdGuard itself (via main UI or systray icon) ➡️ popup content is incorrect, showing "Protection is disabled"
    ↪️ (the popup only correctly shows "Protection is enabled" when it is closed and reopened)

🎥 See video 2 (37 sec.)
 

@contribucious
Copy link
Author

Wow … That was … fast! ☺️

Kudos to the team! ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants