Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary $replace rules warnings in the log #1107

Closed
ameshkov opened this issue Sep 2, 2019 · 1 comment
Closed

Unnecessary $replace rules warnings in the log #1107

ameshkov opened this issue Sep 2, 2019 · 1 comment
Assignees
Milestone

Comments

@ameshkov
Copy link
Member

ameshkov commented Sep 2, 2019

See the details here:
AdguardTeam/AdguardForWindows#2929

WARNING, AdguardSvc, 13, 30.08.2019 20:45:21.392, Adguard.Core.Common.Logging.CoreLoggerAdapter | urlfilter: urlfilter_applyreplace(): Can't apply replace rule '||focus.de$replace=/autoPlay:[\s\S],autoStickiness/autoPlay:false,autoStickiness/,important,~script,~stylesheet,~xmlhttprequest' -- UTF-8 error: isolated byte with 0x80 bit set
WARNING, AdguardSvc, 13, 30.08.2019 20:45:21.395, Adguard.Core.Common.Logging.CoreLoggerAdapter | urlfilter: urlfilter_applyreplace(): Can't apply replace rule '||focus.de$replace=/autoPlay:[\s\S],autoStickiness/autoPlay:false,autoStickiness/,important,~script,~stylesheet,~xmlhttprequest' -- UTF-8 error: isolated byte with 0x80 bit set

Currently, we're using UTF-8 instead of Latin1 and this could cause issues like that.

Possible solutions:

  • If a regex does not contain any UTF-specific characters, use Latin1
  • Just use Latin1 for this type of rules
@vshlobinag
Copy link

core/pull-requests/1490

The problem was with parsing 2 woff2-font binary files that should not be parsed. No encoding changes needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants