Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$replace rules don't work on some websites #1119

Closed
AdamWr opened this issue Sep 12, 2019 · 5 comments
Closed

$replace rules don't work on some websites #1119

AdamWr opened this issue Sep 12, 2019 · 5 comments
Assignees
Milestone

Comments

@AdamWr
Copy link
Member

AdamWr commented Sep 12, 2019

Steps to reproduce

  1. Add this rule:
    ||t66y.com^$replace=/[\s\S]*/Test/
  2. Go here NSFW - https://t66y.com/

Expected behavior

Content should be replaced by $replace rule

Actual behavior

$replace rule doesn't work

Your environment

  • AdGuard for Windows 7.2.2917 (CL 1.4.157)
@AdamWr
Copy link
Member Author

AdamWr commented Sep 14, 2019

It seems that it happens on other websites too - AdguardTeam/AdguardForWindows#2950

@AdamWr AdamWr changed the title $replace rules don't work on t66y.com $replace rules don't work on some websites Sep 14, 2019
@ameshkov
Copy link
Member

Both websites are non-UTF8 websites.

Guys, as I've said before - use Latin1 for $replace rules when you don't know what encoding to use.

@moraks
Copy link

moraks commented Sep 15, 2019

But, in previous ADG 7.1.2817 all user rules work fine. On non-UTF8 websites too, without any special encoding for rules...

@sfionov
Copy link
Member

sfionov commented Sep 15, 2019

@moraks Yes, it is regression.

@vshlobinag
Copy link

core/pull-requests/1498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants