Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$badfilter rules are sensitive to domain lists #1331

Closed
Alex-302 opened this issue Aug 25, 2020 · 4 comments
Closed

$badfilter rules are sensitive to domain lists #1331

Alex-302 opened this issue Aug 25, 2020 · 4 comments

Comments

@Alex-302
Copy link
Member

Original issue:
AdguardTeam/AdguardBrowserExtension#1690

related to #1241 and AdguardTeam/AdguardKnowledgeBase#469

@Alex-302 Alex-302 added the bug label Aug 25, 2020
@sxgunchenko sxgunchenko self-assigned this Aug 25, 2020
@ameshkov ameshkov added this to the v1.8 milestone Aug 25, 2020
@ameshkov
Copy link
Member

This may be really useful

@sxgunchenko
Copy link

core/pull-requests/2100

@AdamWr
Copy link
Member

AdamWr commented Oct 6, 2020

I'm not sure if I should open new issue, but it seems that $badfilter doesn't work in some cases.

Steps to reproduce

Add these rules:

||example.org^$replace=/<h1>[\s\S]*?<\/h1>/<iframe src="https:\/\/www.youtube.com\/embed\/dQw4w9WgXcQ"><\/iframe>/
||youtube.com/embed/
@@||youtube.com/embed/$domain=youtube.com|test.com
@@||youtube.com/embed/$domain=youtube.com|test.com,badfilter

Go here - http://example.org/

Exception rule should be disabled, but it seems that request is unblocked.

Screenshot

image

AdGuard for Windows version 7.5 nightly 33 (build 3407, CL 1.7.114)

@sxgunchenko
Copy link

Looks like a bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants