Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve HTML filtering performance #1772

Closed
ameshkov opened this issue Jun 11, 2023 · 6 comments
Closed

Improve HTML filtering performance #1772

ameshkov opened this issue Jun 11, 2023 · 6 comments

Comments

@ameshkov
Copy link
Member

Currently, HTML filtering adds quite a noticeable overhead to the overall page loading speed.

Steps to reproduce

  1. Open view-source:https://www.rbc.ru/
  2. Measure the loading time (in my case it's about 200ms)
  3. Now add this rule to the user rules: @@||rbc.ru^$content
  4. Refresh the page a few times and measure the loading time
  5. In my case it's about 400ms on average, so a 200ms overhead

What is it that slows it down that much?

Things to do

  1. Change the way it works and keep the overhead in acceptable limits.
  2. Add performance tests specifically for HTML filtering, we shouldn't miss this again.
@emikaadeo-git
Copy link

emikaadeo-git commented Sep 19, 2023

Hi, I have the same issue with Safari and AdGuard for Mac.
The websites loading speeds are noticable slower with AdGuard than without.
I thought it was fixed in #1522 but it's not.
It actually stops me from using AdGuard for Mac.

@sfionov
Copy link
Member

sfionov commented Sep 19, 2023

We sped things up in CL1.13. However, it may take some time before first CL1.13 nightlies.

@emikaadeo-git
Copy link

emikaadeo-git commented Sep 19, 2023

Hi, is there a chance you can backport this fix to CL 1.12 and release with AdGuard 2.12 ?

@SeriousHoax
Copy link

Hi, is there a chance you can backport this fix to CL 1.12 and release with AdGuard 2.12 ?

It would be great if this can be done.

We sped things up in CL1.13. However, it may take some time before first CL1.13 nightlies.

Can you give us an ETA on this? When can we expect a CL 1.13 based Nightly to be released that contains this fix?

@ameshkov
Copy link
Member Author

Expect the first nightlies with it in about 2 weeks from now. There're quite a lot of changes in v1.13, backporting would be problematic.

@SeriousHoax
Copy link

Expect the first nightlies with it in about 2 weeks from now. There're quite a lot of changes in v1.13, backporting would be problematic.

I see, and thanks for sharing the ETA. I'm excited to check out the improvements when it arrives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants