Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$all modifier does not work correctly #1842

Closed
AdamWr opened this issue Dec 23, 2023 · 0 comments
Closed

$all modifier does not work correctly #1842

AdamWr opened this issue Dec 23, 2023 · 0 comments

Comments

@AdamWr
Copy link
Member

AdamWr commented Dec 23, 2023

Steps to reproduce:

  1. Add this rule:
||example.org^$all
  1. Go to - https://example.org/

Expected behavior

There should be message Blocked by AdGuard (like on the screenshot below).

Screenshot

image

Actual behavior

Website is not blocked.


Additional Information

According to https://adguard.com/kb/general/ad-filtering/create-own-filters/#all-modifier

$all modifier is made of all content-types modifiers and $popup. E.g. rule ||example.org^$all is converting into rule:

||example.org^$document,subdocument,font,image,media,object,other,ping,script,stylesheet,websocket,xmlhttprequest,popup

This rule:

||example.org^$document,subdocument,font,image,media,object,other,ping,script,stylesheet,websocket,xmlhttprequest,popup

works fine, the same for:

||example.org^$document,popup

but rule like this - ||example.org^$all does not work.

It doesn't work in version 7.16.0 nightly 13 (4538) (CL 1.13.108, DL 2.4.35) (the same with 7.16 stable version).

It works fine in version 7.15.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants