Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

For IP-based DoT/DoQ connections, IP address is set for SNI #186

Closed
sfionov opened this issue Mar 13, 2023 · 0 comments
Closed

For IP-based DoT/DoQ connections, IP address is set for SNI #186

sfionov opened this issue Mar 13, 2023 · 0 comments
Assignees
@grumaxxx
Labels
Priority: P4 Resolution: Fixed Status: Closed Version: DnsLibs v2.2

Comments

@sfionov
Copy link
Member

sfionov commented Mar 13, 2023 •
edited

This is incorrect behaviour because there is no RFC for setting IP in SNI field.

try:

tls://1.1.1.1
quic://1.1.1.1

tlsext_hostname should not be set, and certificate verification should verify SubjectAltName ip instead of hostname
@sfionov sfionov assigned sfionov and unassigned zzebrum Mar 13, 2023
@adguard-bot adguard-bot assigned grumaxxx and unassigned sfionov Mar 13, 2023
This was referenced May 3, 2023
Closed
Closed
This was referenced Jun 28, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grumaxxx grumaxxx

Labels
Priority: P4 Resolution: Fixed Status: Closed Version: DnsLibs v2.2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sfionov @adguard-bot @zzebrum @grumaxxx