Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying tcp-only and udp-only DNS upstreams #208

Closed
ameshkov opened this issue Nov 1, 2023 · 3 comments
Closed

Allow specifying tcp-only and udp-only DNS upstreams #208

ameshkov opened this issue Nov 1, 2023 · 3 comments
Labels
feature request Priority: P4 Resolution: Fixed Status: Closed Version: DnsLibs v2.5

Comments

@ameshkov
Copy link
Member

ameshkov commented Nov 1, 2023 •
edited

For instance tcp://8.8.8.8 or udp://8.8.8.8
@ameshkov ameshkov mentioned this issue Nov 1, 2023
Closed
4 tasks
@ameshkov ameshkov changed the title Allow specifying tcp-only DNS upstreams Allow specifying tcp-only and udp-only DNS upstreams Nov 1, 2023
@DandelionSprout
Copy link

DandelionSprout commented Nov 1, 2023 •
edited

From how I understand it, simply 8.8.8.8 would already be UDP-only, unless there's some backend stuff I'm unaware of.

tcp:// seems to work in AdGuard for Windows. It works in AdGuard Home. And it worked in AdGuard for Android 3.x, making this situation a feature regression.

The original report being closed with the reasoning of "Just use UDP lol" made me stunned, baffled, and speechless.

@ameshkov
Copy link
Member Author

ameshkov commented Nov 1, 2023

simply 8.8.8.8 would already be UDP-only

Not really, 8.8.8.8 is both UDP and TCP, i.e. when the response is truncated it switches to TCP.

@ameshkov
Copy link
Member Author

ameshkov commented Nov 1, 2023

Relevant task: #209

We need to change all products (AG for Win/macOS/iOS/Android) so that they rely on DnsLibs for this functionality.

This was referenced Dec 14, 2023
Closed
Closed
Closed
Closed
This was referenced Feb 28, 2024
Closed
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Priority: P4 Resolution: Fixed Status: Closed Version: DnsLibs v2.5
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ameshkov @DandelionSprout @adguard-bot