Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying the final CB json file size limit #56

Closed
ameshkov opened this issue Oct 16, 2023 · 0 comments
Closed

Allow specifying the final CB json file size limit #56

ameshkov opened this issue Oct 16, 2023 · 0 comments

Comments

@ameshkov
Copy link
Member

We're facing an issue with Safari not being able to accept content blockers larger than some specific size limit. We need to allow specifying the maximum size limit (size means the final JSON size):
AdguardTeam/AdguardForiOS#2188 (comment)

Currently, it hits the 24MB limit pretty easily when the JSON file is larger than 11MB.

Here's what I suggest:

  1. Allow specifying the upper limit for the final size of the JSON file. Discard all rules that make the JSON file bigger than this limit.
  2. Experiment with different size limits.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants