Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve 'trusted-click-element' — add support for finding selectors in shadowRoot #323

Closed
zloyden opened this issue May 31, 2023 · 1 comment
Closed

Improve 'trusted-click-element' — add support for finding selectors in shadowRoot #323

zloyden opened this issue May 31, 2023 · 1 comment
Assignees
@stanislav-atr
Labels
Feature request Adding new feature Priority: P2 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10

Comments

@zloyden
Copy link

zloyden commented May 31, 2023

According to AdguardTeam/AdguardFilters#152438, it would be nice if the our trusted-click-element could match selectors in shadowRoot(open). I did not find the information about this here.
If it is not possible to do it in the current scriptlet, how about creating another one trusted-click-element-in-shadow-dom?
@zloyden zloyden added the Feature request Adding new feature label May 31, 2023
@adguard-bot adguard-bot changed the title trusted-click-element - add support for finding selectors in shadowRoot Improve 'trusted-click-element' — add support for finding selectors in shadowRoot May 31, 2023
@garry-ut99 garry-ut99 mentioned this issue Nov 21, 2023
Closed
9 tasks
@krystian3w
Copy link

Possible: gorhill/uBlock@941077a So if it doesn't work without diffrent name we have a bug in the AdGuard library.

This was referenced Apr 5, 2024
Open
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stanislav-atr stanislav-atr

Labels
Feature request Adding new feature Priority: P2 Release: v1.10.25 Resolution: Fixed Status: Closed Version: AdGuard v4.3.x patch 3 Version: Scriptlets v1.10
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@adguard-bot @zloyden @krystian3w @slavaleleka @stanislav-atr