Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for setting both screens and cropping #13

Merged
merged 3 commits into from Jul 14, 2020
Merged

Added option for setting both screens and cropping #13

merged 3 commits into from Jul 14, 2020

Conversation

ApoorvaAditya
Copy link
Contributor

Fixes #11

@ApoorvaAditya ApoorvaAditya reopened this Jul 8, 2020
@ApoorvaAditya ApoorvaAditya changed the title Added option for setting both screens Added option for setting both screens and cropping Jul 8, 2020
@ApoorvaAditya
Copy link
Contributor Author

I'm not familiar with Java and Native Android development so there is a bit of code duplication and I am not really sure how to use function overloading properly here so please improve this. I've also not checked for errors when the crop integers are negative or something invalid and how that would affect the package.

@AdityaMulgundkar AdityaMulgundkar merged commit a312533 into AdityaMulgundkar:master Jul 14, 2020
@AdityaMulgundkar
Copy link
Owner

@ApoorvaAditya Thanks a lot for the PR! I have merged your code into master & I'm testing a few things out in the develop branch before pushing it to live on pub.dev. I'll let you know once I've done that.

@AdityaMulgundkar
Copy link
Owner

@ApoorvaAditya Great job on the implementation! I have pushed your code to live on pub.dev (https://pub.dev/packages/wallpaper_manager), you can check the new features by upgrading/setting the version to 1.0.8.

Thank you so much for this.

@ApoorvaAditya
Copy link
Contributor Author

@AdityaMulgundkar Thanks for the merge! Glad I could contribute. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option to set both home screen and lock screen
2 participants