Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation icons in photo view have wrong position #67

Closed
Fasse opened this issue Jun 2, 2015 · 4 comments
Closed

Navigation icons in photo view have wrong position #67

Fasse opened this issue Jun 2, 2015 · 4 comments
Assignees
Milestone

Comments

@Fasse
Copy link
Member

Fasse commented Jun 2, 2015

If you view the photos in the photo module than the navigation icons have wrong position with Chrome and Safari on iPad.

See http://forum.admidio.org/viewtopic.php?p=21359

@ximex
Copy link
Member

ximex commented Jul 9, 2015

I have updated the lib ekko-lightbox. maybe this have fixed this.

I found an other little bug: ashleydw/lightbox#121

@ximex
Copy link
Member

ximex commented Jul 9, 2015

Ok i found a way to fix this. but this has to get fixed in the ekko-lightbox lib.

ekko-lightbox.js Line 315ff

preloadImage: function(src, onLoadShowImage) {
  var img,
    _this = this;
  img = new Image();
  if ((onLoadShowImage == null) || onLoadShowImage === true) {
    img.onload = function() {
      var image;
      image = $('<img />');
      image.attr('src', img.src);
      image.addClass('img-responsive');
      _this.lightbox_body.html(image);
      if (_this.modal_arrows) {
        _this.modal_arrows.css('display', 'block');
      }
      // Start Fix
      image.load(function() {
        _this.resize(img.width);
      });
      // End Fix
      return _this.options.onContentLoaded.call(_this);
    };
    img.onerror = function() {
      return _this.error('Failed to load image: ' + src);
    };
  }
  img.src = src;
  return img;
}

@ximex ximex self-assigned this Aug 7, 2015
@ximex ximex added this to the v3.0.2 milestone Aug 7, 2015
@ximex
Copy link
Member

ximex commented Aug 17, 2015

i created a pull request to fix this bug in the lib. Waiting for merge
ashleydw/lightbox#126

@ximex
Copy link
Member

ximex commented Aug 20, 2015

fixed with 4782b09

@ximex ximex closed this as completed Aug 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants