Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEP8: Wrong and non-changeable extension size #158

Closed
AAverin opened this issue Jan 9, 2018 · 24 comments
Closed

CEP8: Wrong and non-changeable extension size #158

AAverin opened this issue Jan 9, 2018 · 24 comments

Comments

@AAverin
Copy link

AAverin commented Jan 9, 2018

Platform: CEP8 Adobe CC 2018
Product: Adobe Photoshop 2018

If extension was already installed and is updated with the new version, window for the new extension version sets the wrong size and window can't be resized

@zimag
Copy link

zimag commented Jan 9, 2018

Try to use the new

<Geometry>
	<Size>
		<Width>400</Width>
		<Height>300</Height>
	</Size>
	<MaxSize>
		<Height>2160</Height>
		<Width>3840</Width>
	</MaxSize>
	<MinSize>
		<Height>10</Height>
		<Width>256</Width>
	</MinSize>
</Geometry>

structure and use dimensions multiplied by 2.

At first I had the same issue but now all the windows are resizeable.

@AAverin
Copy link
Author

AAverin commented Jan 9, 2018

I have this geometry at the moment:

<Geometry>
                        <Size>
                            <Height>380</Height>
                            <Width>300</Width>
                        </Size>
                        <MaxSize>
                            <Height>380</Height>
                            <Width>400</Width>
                        </MaxSize>
                        <MinSize>
                            <Height>380</Height>
                            <Width>250</Width>
                        </MinSize>
                    </Geometry>

how do you propose to change it?

@zimag
Copy link

zimag commented Jan 9, 2018

Try to double the maximum dimensions. Them must be some sort of retina or dpi dependent values.
Or give them extreme high values.

@AAverin
Copy link
Author

AAverin commented Jan 9, 2018

I see, thanks.
Would be also great to have some kind of official response from CEP developers on this matter.
So far it looks like a bug to me, or I am missing some requirements for size dimensions that would make it work

@undavide
Copy link

undavide commented Jan 9, 2018

As far as I know, it is an acknowledged bug. It should have been logged – we waited for a fix in the first PS update, but it didn't arrive (or it didn't work as expected).

@AAverin
Copy link
Author

AAverin commented Jan 9, 2018

I will try playing with size values.
Any other known workarounds already?
Maybe a script to disable and re-enable extension via Window -> Extensions?

@VishakhaVaidya
Copy link
Contributor

There are a few bugs related to resizing, that we are fixing.
@AAverin for the values you are using, the extension should be resizable until the min and max values, unless its a part of panel group which overrides the min and max limits. If you undock it and are still not able to resize, its definitely a bug.
@zimag extension developers should not be bothered about monitor dpi, thats taken care of by application and CEP, if the application is dpi aware.

@AAverin
Copy link
Author

AAverin commented Jan 9, 2018

@VishakhaVaidya I have a screenshot from an alpha-tester with panel undocked and wrong size. Can't really see if panel is non-resizeable, but that's what other testers complained about.
I myself saw this behaviour with panel docked – panel group was not resizeable with my panel inside

@VishakhaVaidya
Copy link
Contributor

@AAverin This looks like a bug we are already fixing. I will check it after the fix. Can you help me with some more info,

  1. is this happening with a monitor scale factor greater than 1
  2. Is this a platform specific behavior, happening only on win or mac?

Thanks.

@zimag
Copy link

zimag commented Jan 10, 2018

I have to double the dimensions with PS GUI scale factor of 1 on Win10.

@AAverin
Copy link
Author

AAverin commented Jan 10, 2018

@VishakhaVaidya
I have played around a bit more and looks like the issue is:

  • if panel is already attached to a group and you change manifest, restart Photoshop, size is updated and may look correct. But, once you detach the panel of the group – size starts to draw somehow wrong, shorter. If you then put panel back to the group size is still wrong.

So what I did in the end – fixed my size and made it larger. Now panel is not cut when detached anymore, but it might show up larger then needed when attached to a group.

So as I see, there seems to be a size bug related to groups of panels.

Advice to people that have this issue: after updating sizes in manifest make sure you detach your panel and double check sizes

@VishakhaVaidya
Copy link
Contributor

@AAverin thanks for the info, I will take a look.

@rasesh1995
Copy link
Contributor

@AAverin I am unable to reproduce the issue. Can you attach a video of what causes the issue to happen to enable me to fix it

@undavide
Copy link

FYI, it happens to me on Sierra + HighSierra, will try to record a video asap.

@zimag
Copy link

zimag commented Jan 18, 2018

Completely forgot that I can't reisize my panels either, except if they are docked together with a native Timeline panel. If this panel is present in the column of panels the resizing magically working. All I have to to is to put a collapsed Timeline or other panel between them.

@zimag
Copy link

zimag commented Jan 18, 2018

Was there an update today in the background?
Just asking because now I can freely resize the undocked panels.

By the way, If the panel resizing is fixed, thanks a lot!

Update:
I was wrong. The panels are still behaving weirdly both docked and undocked, when native panels docked or not.

@AAverin
Copy link
Author

AAverin commented Jan 21, 2018

Just in case David didn't send you anything yet, here is a video of the bug (Video is unlisted on Youtube)
https://youtu.be/BhJp1r38SvM

By default, panel opens in a tab group, where size is calculated wrong.
Detaching a panel into icon fixes size problem, and size is calculated correctly even if after you re-attach it to the same group

@bialikover
Copy link

Any updates on this issue?

@ErinFinnegan
Copy link
Contributor

@bialikover There were several bug reports internally, like CEP-826 and CEP-940.

I'm still asking around, but the bug seems to have been fixed for CEP 9, which is currently in prereleases.

@ErinFinnegan
Copy link
Contributor

Hi @bialikover! I have confirmed that this bug is fixed in the upcoming release of CEP 9, and there are currently no plans to fix it in CEP 8. I suspect this might then affect some products if they happen to have a maximum of CEP 8 support. When CEP 9 comes out there will likely be a version chart similar to the one in the CEP Cookbook.

I could be wrong, though...

@AAverin
Copy link
Author

AAverin commented Aug 28, 2018

@ErinFinnegan thanks for clarification.
Do you have some mailing list I can subscribe to be informed about pre-releases so I could update my product for new version beforehand?

@ErinFinnegan
Copy link
Contributor

@AAverin got in touch with me, and I added him to the new Adobe Creative Cloud Developer Newsletter (online signup form coming soon).

Pre-release information for different products are listed in this blog post, and if you follow the Adobe Tech blog, we'll announce it there when CEP 9 goes public.

@ErinFinnegan
Copy link
Contributor

This is fixed in CEP 9, so this issue can be closed. (@prernavij ?)

Here's the newsletter sign up link: https://adobe.ly/devnews

@prernavij
Copy link
Contributor

Closing as it's fixed as Erin mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants