Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelsbuilder #15

Closed
wants to merge 20 commits into from
Closed

Modelsbuilder #15

wants to merge 20 commits into from

Conversation

idseefeld
Copy link
Collaborator

@idseefeld idseefeld commented Oct 9, 2021

Hi Dennis,
I think this is a good starting point for a Models Builder setup.

  • Upgrade to Umbraco release version 9.0.0
  • small bugfixes for search
  • Models are generated in the .Core project
  • hard coded property alias constants are obsolete now!
  • manual mapping of these models int simple POCO view models are mostly done in page controllers (for SitePageBase base class I use an extension method viewModel.MapSitePageBase())
  • updated tests (need to setup all view model properties with empty values. I'm not sure this is the best approach🤔 Do you have an idea?)

I am looking forward for your review. Have a nice weekend!

Dirk

@Adolfi
Copy link
Owner

Adolfi commented Nov 24, 2021

Hi Dirk.
First let me just start of with apologising for not responding to this PR for so long. I've had soo much in my personal life these last few months that I haven't had the time to review this.

Could I ask you to point this PR to the newely created modelsbuilder branch ive created, so that we can merge it and work together on it before we merge it to the master branch. Is that ok with you?

@idseefeld
Copy link
Collaborator Author

idseefeld commented Nov 24, 2021 via email

@idseefeld
Copy link
Collaborator Author

There is a new branch for this update.

@idseefeld idseefeld closed this Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants