Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy for retiring nightly builds #112

Closed
karianna opened this issue Sep 6, 2019 · 4 comments
Closed

Policy for retiring nightly builds #112

karianna opened this issue Sep 6, 2019 · 4 comments

Comments

@karianna
Copy link
Member

karianna commented Sep 6, 2019

adoptium/installer#127 raised the discussion of how long we should keep nightlies (raw binaries and/or installers).

At present, we keep forever. One proposal is to keep the last 7 days + 1 from each preceding month.

@karianna karianna added this to the September 2019 milestone Sep 6, 2019
@karianna karianna added this to TODO in openjdk-tsc via automation Sep 6, 2019
@tresf
Copy link

tresf commented Sep 6, 2019

From a bug-reporting perspective, I feel a week is fair as long as the OP is clearly instructed to grab a copy of the nightly before it expires.

Reason: A week isn't always long enough to completely finish a bug's unit tests. The way other projects generally handle this is, the one-off-fix will be attached/linked in binary form to the bug report. Assuming this redundant exercise is to be avoided for efficiency purposes, OPs need to be told to save the binaries before they expire. It could be argued that any nightly would have the patch for unit testing -- and that's usually true -- but regressions exist, so having someone snag it ensures they're going up against the minimal amount of variance.

@karianna
Copy link
Member Author

karianna commented Sep 6, 2019

From a bug-reporting perspective, I feel a week is fair as long as the OP is clearly instructed to grab a copy of the nightly before it expires.

Reason: A week isn't always long enough to completely finish a bug's unit tests. The way other projects generally handle this is, the one-off-fix will be attached/linked in binary form to the bug report. Assuming this redundant exercise is to be avoided for efficiency purposes, OPs need to be told to save the binaries before they expire. It could be argued that any nightly would have the patch for unit testing -- and that's usually true -- but regressions exist, so having someone snag it ensures they're going up against the minimal amount of variance.

That's a fair call - I suspect given the OSS/Community nature of this project that 7 days is a little aggressive. I'm wondering if a whole month's worth is more realistic.

@smlambert
Copy link

A month is my preference.

@karianna karianna modified the milestones: September 2019, October 2019 Oct 4, 2019
@karianna karianna modified the milestones: October 2019, November 2019 Nov 19, 2019
@karianna karianna modified the milestones: November 2019, December 2019 Dec 4, 2019
@karianna karianna modified the milestones: December 2019, January 2020 Jan 16, 2020
@karianna karianna modified the milestones: January 2020, February 2020 Feb 12, 2020
@karianna karianna modified the milestones: February 2020, March 2020 Mar 6, 2020
@karianna karianna modified the milestones: March 2020, April 2020 Apr 7, 2020
@karianna karianna modified the milestones: April 2020, May 2020 May 6, 2020
@karianna karianna modified the milestones: May 2020, June 2020 Jun 11, 2020
@karianna karianna modified the milestones: June 2020, July 2020 Jul 15, 2020
@karianna karianna modified the milestones: July 2020, August 2020 Aug 2, 2020
@karianna karianna removed this from the August 2020 milestone Sep 8, 2020
@karianna karianna added this to the September 2020 milestone Sep 8, 2020
@karianna karianna modified the milestones: September 2020, October 2020 Oct 1, 2020
@karianna karianna modified the milestones: October 2020, November 2020 Nov 5, 2020
@karianna karianna modified the milestones: November 2020, December 2020 Dec 2, 2020
@gdams gdams mentioned this issue Dec 7, 2020
@karianna karianna modified the milestones: December 2020, March 2021 Mar 9, 2021
@karianna karianna modified the milestones: March 2021, April 2021 Apr 18, 2021
@karianna
Copy link
Member Author

Adoptium decision

openjdk-tsc automation moved this from TODO to Done Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
openjdk-tsc
  
Done
Development

No branches or pull requests

3 participants