Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate generator jobs #41

Closed
wants to merge 12 commits into from
Closed

Conversation

M-Davies
Copy link
Contributor

@M-Davies M-Davies commented Feb 16, 2021

  • Adds a generator job that, executed on git push to master, will regenerate the generator jobs
  • Will also pass down params to the generator jobs to ensure they run correctly when it completes
  • Will also trigger a building of said jobs after SUCCESSFULL completion to ensure everything is generated up to date
  • Changes regeneration/ directory name to generation/
  • Moves all template files into their own directory and renames them to make more sense
  • Doc and linter updates to account for changes

Closes: #10
Signed-off-by: Morgan Davies morgandavies2020@gmail.com

@M-Davies M-Davies added enhancement generation Issues that provide enhancements or fixes to the job generators labels Feb 16, 2021
@M-Davies M-Davies self-assigned this Feb 16, 2021
@M-Davies M-Davies added this to In progress in ci-jenkins-pipelines via automation Feb 16, 2021
@M-Davies M-Davies marked this pull request as draft February 16, 2021 16:58
@github-actions
Copy link

Thank you for creating a pull request!
In order to run the pipeline tests I require an admin to post the following comment: run tests

@karianna karianna added this to the February 2021 milestone Feb 17, 2021
@M-Davies M-Davies force-pushed the generate_pipeline branch 6 times, most recently from 21e65b6 to 869d63e Compare February 20, 2021 17:07
* Adds a generator job that, executed on git push to master, will regenerate the generator jobs
* Will also pass down params to the generator jobs to ensure they run correctly when it completes
* Will also trigger a building of said jobs after SUCCESSFULL completion to ensure everything is generated up to date
* Refactors where the downstream base file is located
* Doc updates to account for changes

Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
@M-Davies
Copy link
Contributor Author

M-Davies commented Feb 22, 2021

Blocked by #42 MERGED

@M-Davies M-Davies added blocked and removed blocked labels Feb 22, 2021
@gdams gdams changed the title Generate generator jobs generate generator jobs Mar 9, 2021
@M-Davies M-Davies changed the title generate generator jobs Generate generator jobs Mar 31, 2021
@karianna karianna modified the milestones: March 2021, April 2021 Apr 1, 2021
docs/ARCHITECTURE.md Outdated Show resolved Hide resolved
Co-authored-by: George Adams <george.adams@microsoft.com>
@github-actions github-actions bot added testing generation Issues that provide enhancements or fixes to the job generators and removed generation Issues that provide enhancements or fixes to the job generators labels Apr 13, 2021
@karianna karianna modified the milestones: April 2021, May 2021 May 4, 2021
@karianna karianna modified the milestones: May 2021, June 2021 Jun 6, 2021
@karianna
Copy link
Contributor

@M-Davies Would you be able to rebase this or should we close it?

@M-Davies
Copy link
Contributor Author

Probably best to close. Last I checked, this isn't needed that badly and may just create more problems than it's worth

@M-Davies M-Davies closed this Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement generation Issues that provide enhancements or fixes to the job generators jenkins-pipeline refactoring testing
Projects
No open projects
ci-jenkins-pipelines
  
In progress
Development

Successfully merging this pull request may close these issues.

Regenerator of regenerators
3 participants