Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out contents of openjdk-build into openjdk-build and openjdk-build-farm #1108

Open
karianna opened this issue May 30, 2019 · 10 comments
Open
Assignees
Labels
enhancement Issues that enhance the code or documentation of the repo in any way refactoring Issues that focus on moving around the codebase inside or between repos
Milestone

Comments

@karianna
Copy link
Contributor

The build farm code should be kept separate from the code used to actually build openjdk for folks at home.

@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label May 30, 2019
@karianna karianna added this to TODO in temurin-build via automation May 30, 2019
@sxa
Copy link
Member

sxa commented Jun 17, 2019

I'm not yet convinced by this. If you take the scenario where someone wants to setup up a build system and run our builds then some of the details (the environment files) are only invoked when you run our build-farm scripts. Separating these out into another repository would currently make that use case unnecessarily complex by introducing another repository into the mix.

@gdams
Copy link
Member

gdams commented Jun 17, 2019

Certainly things like the git-hg scripts can be pulled out IMO

@grzesuav
Copy link

@sxa555 When I tried to use the scripts last time for building java8, the gradle complains that java used there (zulu-7) is too old - it needs jdk8. So IMHO those code should be kept separate.

@adamfarley
Copy link
Contributor

If there is no appetite for continuing this discussion, should it and #913 be closed?

@karianna
Copy link
Contributor Author

karianna commented Nov 3, 2020

This one should stay - it needs to get done

@M-Davies M-Davies added the refactoring Issues that focus on moving around the codebase inside or between repos label Nov 27, 2020
@karianna
Copy link
Contributor Author

karianna commented Dec 4, 2020

https://docs.google.com/document/d/1_n7n7yZijdBVLhQcaljogOT-Nd_JJLoCR05JSgkgfOA/edit?usp=sharing draft proposal

@M-Davies
Copy link
Contributor

@karianna I noticed that the roadmap doesn't mention the build farm at all. And it also appears that the build-farm is to stay in this repo. If that is true, can we close this issue (and if not, does the doc need updating?)

@karianna karianna moved this from TODO to In Progress in temurin-build Feb 18, 2021
@karianna karianna added this to the February 2021 milestone Feb 18, 2021
@karianna
Copy link
Contributor Author

@karianna I noticed that the roadmap doesn't mention the build farm at all. And it also appears that the build-farm is to stay in this repo. If that is true, can we close this issue (and if not, does the doc need updating?)

The build farm should get split out - I've updated the doc accordingly.

@sxa
Copy link
Member

sxa commented Mar 8, 2021

The build farm should get split out - I've updated the doc accordingly.

This seems to have been added to the doc since I last saw it. What's the driving reason for splitting out those two? To my mind that adds extra complexity with no significantly visible benefit. Is it part of a larger plan somewhere - I feel that needs more discussoin/justification (Particularly given the problems we've had with the pipelines split)?

@karianna
Copy link
Contributor Author

The build farm should get split out - I've updated the doc accordingly.

This seems to have been added to the doc since I last saw it. What's the driving reason for splitting out those two? To my mind, that adds extra complexity with no significantly visible benefit. Is it part of a larger plan somewhere - I feel that needs more discussion/justification (Particularly given the problems we've had with the pipelines split)?

This is making sure there's a clean split between what configuration we use for the Eclipse Adoptium/Temurin build farm vs. pipeline scripts that anyone can utilize. It's another important separation of concerns step to make sure that we're truly serving the needs for the vendors or folks who might run this within their orgs.

On balance it maybe that all we need to do is refactor the pipeline scripts so that adopt values are set as defaults and can be overridden. Will need some investigation. I've updated the doc again accordingly.

@karianna karianna modified the milestones: February 2021, March 2021 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues that enhance the code or documentation of the repo in any way refactoring Issues that focus on moving around the codebase inside or between repos
Projects
No open projects
temurin-build
  
In Progress
Development

No branches or pull requests

6 participants