Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenJ9 configure arguments broken on JDK14 #1656

Closed
M-Davies opened this issue Apr 7, 2020 · 11 comments · Fixed by #1657
Closed

OpenJ9 configure arguments broken on JDK14 #1656

M-Davies opened this issue Apr 7, 2020 · 11 comments · Fixed by #1657
Assignees
Labels
bug Issues that are problems in the code as reported by the community
Milestone

Comments

@M-Davies
Copy link
Contributor

M-Davies commented Apr 7, 2020

Platform/Architecture
windows_x64 OpenJ9 builds

Running custom generated-configure.sh
configure: error: unrecognized options: --with-version-opt, --without-version-pre, --with-version-build, --with-vendor-version-string, --disable-warnings-as-errors
@karianna karianna added this to TODO in temurin-build via automation Apr 7, 2020
@karianna karianna added this to To do in Top Priorities via automation Apr 7, 2020
@karianna karianna added the bug Issues that are problems in the code as reported by the community label Apr 7, 2020
@karianna karianna added this to the April 2020 milestone Apr 7, 2020
@M-Davies
Copy link
Contributor Author

M-Davies commented Apr 7, 2020

Tested all potential options on local instance and all exist so likely a machine issue.

For the record, the configure options are not being recognised on build-softlayer-win2012r2-x64-1

@andrew-m-leonard
Copy link
Contributor

note that's a jdk14u build however console log thinks it is building jdk8u, hence why options not valid...

OpenJDK repo tag is jdk8u252-b08
Version: 252 
Should have the source, I'm at /tmp/openjdk-build/workspace/build/src
OpenJDK repo tag is jdk8u252-b08

@sxa
Copy link
Member

sxa commented Apr 7, 2020

@gdams could this be a result of the different way we now use a shortened workspace path name?

@andrew-m-leonard
Copy link
Contributor

andrew-m-leonard commented Apr 7, 2020

This line does not check source out for JDK14:
https://github.com/AdoptOpenJDK/openjdk-build/blob/820ec4633433c821ba7634c93a3b7d50ec38b3bd/sbin/prepareWorkspace.sh#L50

neither for jdkNext either

@andrew-m-leonard
Copy link
Contributor

Not sure why that line checks the version... why not do it for all..?

@sxa
Copy link
Member

sxa commented Apr 7, 2020

@johnoliver ?

@johnoliver
Copy link
Contributor

I agree I am not sure why we need to check the version there, so I would remove that version check

@karianna
Copy link
Contributor

karianna commented Apr 7, 2020

#1657

@karianna karianna linked a pull request Apr 7, 2020 that will close this issue
@karianna karianna self-assigned this Apr 7, 2020
@karianna karianna moved this from TODO to In Progress in temurin-build Apr 7, 2020
@karianna karianna moved this from To do to In progress in Top Priorities Apr 7, 2020
temurin-build automation moved this from In Progress to Done Apr 7, 2020
Top Priorities automation moved this from In progress to Done Apr 7, 2020
@karianna
Copy link
Contributor

karianna commented Apr 7, 2020

@M-Davies Can you try a new run and see what happens please?

@sxa
Copy link
Member

sxa commented Apr 7, 2020

@M-Davies @lumpfish I've kicked off a 14 pipeline without publish or tests so we we can see how it goes https://ci.adoptopenjdk.net/job/build-scripts/job/openjdk14-pipeline/105/

@M-Davies
Copy link
Contributor Author

M-Davies commented Apr 7, 2020

Looks like https://ci.adoptopenjdk.net/job/build-scripts/job/jobs/job/jdk14u/job/jdk14u-windows-x64-openj9/32/consoleFull is running fine. Its passed the configure stage and is building. Thanks for this :-)

@gdams gdams removed this from Done in Top Priorities Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that are problems in the code as reported by the community
Projects
No open projects
temurin-build
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants