Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retry logic for build prepareWorkspace checkout #1843

Merged
merged 1 commit into from
Jun 10, 2020
Merged

Add retry logic for build prepareWorkspace checkout #1843

merged 1 commit into from
Jun 10, 2020

Conversation

andrew-m-leonard
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard commented Jun 9, 2020 •
edited

This PR adds a retry logic to the prepareWorkspace checkout logic, to handle cases of failure due to corrupt/invalid caches.
It also adds more verbose failure output for better diagnosis.

Signed-off-by: andrew-m-leonard andrew_m_leonard@uk.ibm.com

@andrew-m-leonard andrew-m-leonard changed the title Add retry logic for build prepareWorkspace checkout WIP: Add retry logic for build prepareWorkspace checkout Jun 9, 2020
@karianna karianna marked this pull request as draft June 9, 2020 14:07
@karianna karianna added the enhancement Issues that enhance the code or documentation of the repo in any way label Jun 9, 2020
@karianna karianna added this to TODO in temurin-build via automation Jun 9, 2020
@karianna karianna added this to the June 2020 milestone Jun 9, 2020
@karianna karianna moved this from TODO to In Progress in temurin-build Jun 9, 2020
@karianna karianna linked an issue Jun 9, 2020 that may be closed by this pull request
prepareWorkspace.sh build workspace cache fails frequently #1840
Closed
@andrew-m-leonard andrew-m-leonard marked this pull request as ready for review June 9, 2020 20:18
@andrew-m-leonard
Copy link
Contributor Author

andrew-m-leonard commented Jun 9, 2020 •
edited

Tested this here: https://ci.adoptopenjdk.net/view/work%20in%20progress/job/andrew-jdk14u-linux-x64-openj9/
Tested on Hotspot, OpenJ9, xLinux, Windows
Variations:

  • previous workspace cache different version
  • no previous cache
  • previous cache correct version
  • provide bad scm_ref to force retry

@andrew-m-leonard andrew-m-leonard self-assigned this Jun 9, 2020
@andrew-m-leonard andrew-m-leonard changed the title WIP: Add retry logic for build prepareWorkspace checkout Add retry logic for build prepareWorkspace checkout Jun 9, 2020
@andrew-m-leonard andrew-m-leonard mentioned this pull request Jun 10, 2020
Closed
karianna
karianna requested changes Jun 10, 2020
View reviewed changes
sbin/prepareWorkspace.sh Outdated Show resolved Hide resolved
Add retry logic for build prepareWorkspace checkout
4747e59 
Signed-off-by: andrew-m-leonard <andrew_m_leonard@uk.ibm.com>
@andrew-m-leonard
Copy link
Contributor Author

@karianna
Combined the lines to make more readable
Verified: https://ci.adoptopenjdk.net/view/work%20in%20progress/job/andrew-jdk14u-linux-x64-openj9/15/console

karianna
karianna approved these changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 5a84d61 into adoptium:master Jun 10, 2020
temurin-build automation moved this from In Progress to Done Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

Assignees

@andrew-m-leonard andrew-m-leonard

Labels
enhancement Issues that enhance the code or documentation of the repo in any way
Projects
No open projects
temurin-build
  
Done
Milestone
June 2020
Development

Successfully merging this pull request may close these issues.

prepareWorkspace.sh build workspace cache fails frequently
2 participants
@andrew-m-leonard @karianna