Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x32 Windows to jdk16 #2076

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Add x32 Windows to jdk16 #2076

merged 1 commit into from
Sep 24, 2020

Conversation

M-Davies
Copy link
Contributor

Closes: #2072
Signed-off-by: Morgan Davies morgandavies2020@gmail.com

@M-Davies
Add x32 Windows to jdk16
775d3b3 
Signed-off-by: Morgan Davies <morgandavies2020@gmail.com>
@M-Davies M-Davies added important High priority issues that are not buildbreakers but may still require more attention than others windows Issues that affect or relate to the WINDOWS OS new builds Issues that request for new jenkins pipeline builds labels Sep 11, 2020
@M-Davies M-Davies marked this pull request as draft September 11, 2020 13:34
@M-Davies
Copy link
Contributor Author

run tests

@adoptopenjdk-github-bot
Copy link
Contributor

🟠 PR TESTER RESULT 🟠

❎ Some pipelines failed or the job was aborted! ❎
See the pipeline-build-check below for more information...

@M-Davies
Copy link
Contributor Author

PR Tester produced this error when attempting to run it. Query has been raised in slack to verify the legitimacy of this error

14:56:39  Removing current git repo as it is the wrong type
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/adGlobals_x86_32.hpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32.hpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32_clone.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32_expand.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32_format.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32_gen.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32_misc.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32_peephole.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/ad_x86_32_pipeline.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/dfa_x86_32.cpp': Device or resource busy
14:56:39  rm: cannot remove '/cygdrive/j/jenkins/tmp/workspace/./build//src/build/windows-x86-normal-clientANDserver-release/hotspot/windows_i486_compiler2/generated/x86_32.ad': Device or resource busy

It was on build-azure-win2012r2-x64-2

@adoptium adoptium deleted a comment from gdams Sep 11, 2020
@M-Davies
Copy link
Contributor Author

run tests

@adoptopenjdk-github-bot
Copy link
Contributor

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

@M-Davies
Copy link
Contributor Author

This test run seemed a lot healthier than the last (this run was on build-azure-win2012r2-x64-1) The previous error has been raised on slack.

@Willsparker Willsparker mentioned this pull request Sep 14, 2020
Closed
@Willsparker
Copy link
Contributor

@M-Davies As far as I can tell, there was a process running on the machine using those files, so the run was unable to delete them. When I got round to manually clearing them this morning, I was able to delete it with no issues - feel free to try again on that machine :-)

@M-Davies
Copy link
Contributor Author

@M-Davies As far as I can tell, there was a process running on the machine using those files, so the run was unable to delete them. When I got round to manually clearing them this morning, I was able to delete it with no issues - feel free to try again on that machine :-)

Thanks @Willsparker

@M-Davies
Copy link
Contributor Author

run tests

@adoptopenjdk-github-bot
Copy link
Contributor

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

@karianna karianna added this to TODO in temurin-build via automation Sep 15, 2020
@karianna karianna added this to the September 2020 milestone Sep 15, 2020
@karianna karianna moved this from TODO to In Progress in temurin-build Sep 15, 2020
karianna
karianna requested changes Sep 15, 2020
View reviewed changes
pipelines/build/prTester/pr_test_pipeline.groovy Outdated
"hotspot"
],
"x64Mac": [
"x32Windows": [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about this change - why remove the others and only have win32?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is clearly for testing, needs to be reverted. The PR is in draft form right now though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it's for testing purposes only to prevent the pr tester from running everything. I'll remove the 2nd commit (the one that removes the platforms) before I move this out of draft

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit has been removed. @gdams @karianna Could I get reviews again?

@M-Davies M-Davies marked this pull request as ready for review September 22, 2020 11:08
karianna
karianna approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@M-Davies M-Davies requested a review from gdams September 22, 2020 18:16
@adoptopenjdk-github-bot
Copy link
Contributor

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

@karianna
Copy link
Contributor

Waiting for OpenJ9 release to clear

@gdams gdams merged commit fd20a85 into adoptium:master Sep 24, 2020
temurin-build automation moved this from In Progress to Done Sep 24, 2020
@M-Davies M-Davies deleted the windows16 branch April 30, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@gdams gdams gdams approved these changes

Assignees
No one assigned
Labels
important High priority issues that are not buildbreakers but may still require more attention than others new builds Issues that request for new jenkins pipeline builds windows Issues that affect or relate to the WINDOWS OS
Projects
No open projects
temurin-build
  
Done
Milestone
September 2020
Development

Successfully merging this pull request may close these issues.

Add x86 Windows (32 bit) to the 16 pipelines
5 participants
@M-Davies @adoptopenjdk-github-bot @Willsparker @karianna @gdams