Remove Node Existence Check Prior to Docker Build #2146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker nodes do not exist prior to us trying to use them, as they are dynamically generated. So waiting for one to become active prior to use is a futile effort, and the inevitable timeout causes build failure. So this change removes the "wait for active node" step from the docker builds. Signed-off-by: Adam Farley <adam.farley@uk.ibm.com>
gdams
approved these changes
Oct 15, 2020
|
run tests |
This was referenced Oct 15, 2020
karianna
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker nodes do not exist prior to us trying to use them, as they
are dynamically generated.
So waiting for one to become active prior to use is a futile effort,
and the inevitable timeout causes build failure.
So this change removes the "wait for active node" step from the
docker builds.
Signed-off-by: Adam Farley adam.farley@uk.ibm.com