Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify debug-image and debug-symbols creation option #2393

Merged
merged 2 commits into from
Jan 25, 2021
Merged

Unify debug-image and debug-symbols creation option #2393

merged 2 commits into from
Jan 25, 2021

Conversation

milderhc
Copy link
Contributor

debug-image and debug-symbols archives were the same. I'm removing the debug-symbols folder and archive creation and instead redirect that logic to create a debug-image archive.

By default, for OpenJ9 the debug-image will be created (as it was already working), for other platforms, we must add the --create-debug-image option.

@milderhc milderhc mentioned this pull request Jan 19, 2021
Closed
@karianna karianna added this to In Progress in temurin-build via automation Jan 19, 2021
@karianna karianna added this to the January 2021 milestone Jan 19, 2021
@karianna karianna added enhancement Issues that enhance the code or documentation of the repo in any way awaiting-merge-post-release Pull Requests that have been approved but won't be merged until our release is over labels Jan 19, 2021
karianna
karianna approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for post GA release testing (I bet we find stuff that will shake out here)

@M-Davies
Copy link
Contributor

run tests

@adoptopenjdk-github-bot
Copy link
Contributor

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

M-Davies
M-Davies approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@M-Davies M-Davies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for post release

temurin-build automation moved this from In Progress to Review/QA Jan 19, 2021
andrew-m-leonard
andrew-m-leonard approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna karianna merged commit 38ac9bc into adoptium:master Jan 25, 2021
temurin-build automation moved this from Review/QA to Done Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@M-Davies M-Davies M-Davies approved these changes

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

Assignees
No one assigned
Labels
awaiting-merge-post-release Pull Requests that have been approved but won't be merged until our release is over enhancement Issues that enhance the code or documentation of the repo in any way
Projects
No open projects
temurin-build
  
Done
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@milderhc @M-Davies @adoptopenjdk-github-bot @karianna @andrew-m-leonard