Create new node #15
Merged
Create new node #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamBrousseau
suggested changes
Apr 10, 2018
| static final String WGET_SLAVE_JAR = "\"wget -q --no-check-certificate -O slave.jar ${SLAVE_JAR_LOCATION} ; java -jar slave.jar\""; | ||
| static final String SSH_COMMAND = "ssh -C -i ${SSH_KEY_LOCATION} <userName/>@"; | ||
| static final String SSH_KEY_LOCATION = ""; | ||
| } |
There was a problem hiding this comment.
Please add a new line at the end of the file.
Jenkins_jobs/CreateNewNode.groovy
Outdated
| List<String> newMachines = new ArrayList<String>(); | ||
|
|
||
| node { | ||
| stage('jenkins made me do it') { |
There was a problem hiding this comment.
Perhaps a more descriptive stage name?
Jenkins_jobs/CreateNewNode.groovy
Outdated
| // This will be used to get the names of machines that need to have description updated | ||
| newMachines.add(newMachineName); | ||
| } else { | ||
| echo "Machine(${machines[index]}) already exists." |
There was a problem hiding this comment.
Please reverse this if to have the error at the start
Jenkins_jobs/CreateNewNode.groovy
Outdated
| if (launcher.getClass().toString().contains("slaves.CommandLauncher")) { | ||
| for (ScriptApproval.PendingScript script : scriptSet) { | ||
| // TODO: Search for entire string instead of a part | ||
| if (script.script.contains("ssh -C -i /data/jenkins/J9_Build/home/.ssh/j9build.key j9build@" + machineIPs[index])) { |
There was a problem hiding this comment.
I don't like this string hardcoded here, shouldn't we be using the Constants file?
AdamBrousseau
suggested changes
Apr 11, 2018
- Added CreateNewNode job - Updated readme file to include the new job - Moved string constants to the vars directory of the Node helper API - added a input parameter for SSH key id in CreateNewNode issue adoptium#10 Signed-off-by: Shubham Verma <shubhamv.sv@gmail.com>
AdamBrousseau
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added create new node part of NodeMaintaince job. This is a standalone job that calls the API to add new node. Along with the new job I have also fixed a few bugs in NodeHelper API.