-
-
Notifications
You must be signed in to change notification settings - Fork 301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multple JDI tests failing on JDK8-s390x_Linux (scaffold issue?) #1737
Comments
Exclude PR #1738 |
@M-Davies FYI you can actually link PR's on the RH side of a GitHub issue 'Linked Pull Requests' |
@karianna Can this be reopened? The issue still persists, the PR was just to exclude it from the nightly testing so we don't keep seeing known failures :) |
Discounting any infra problems, it seems likely it's something in this timeframe https://github.com/AdoptOpenJDK/openjdk-jdk8u/compare/master@%7B02-23-2020%7D...master@%7B04-09-2020%7D that is the cause of the failures since runs prior to 23rd Feb are green. |
The range of commits above looks fine to me. I'll take a closer look at some of these scaffoding tests |
Looking at TestScaffold specifically, there doesn't seem to be anything glaringly obvious that is wrong. This is used in EarlyReturnTest.java.
It is this line specifically that is throwing the errors as shown above. It appears the VM is not setup correctly, I'll see if I can spit out some debugging output to check the versions and capability of the VM. |
So
|
That does bring into question the output further up in the test when it pumps out the version of the JVM version. I wonder where it is getting this JVM information from.
It would be good to compare this test against a machine that isn't a Running a grinder on our s390x machine that isn't I'll see if I can get hold of one on Fyre |
Ran a couple of internal grinders since fyre appears to be down. Both failed in the same way. @smlambert could you take a look at this? |
Ran a modified version of the failing line without the
Cross checking with https://docs.oracle.com/javase/8/docs/jdk/api/jpda/jdi/com/sun/jdi/ThreadReference.html#forceEarlyReturn-com.sun.jdi.Value-, this rules out a few options. I have also noticed that there are two references to |
These have not been seen recently and my grinder passed https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/7653/console so assuming these have all been fixed |
Reopen as test has been excluded. The grinder without test re-enabled doesn't means the issue has been fixed. |
Describe the bug
In the nightlies, we have 9 tests that are consistently failing on JDK8 zlinux. I'll use this issue as a convenient dumping ground for them all as they all seem to be related
To Reproduce
Steps to reproduce the behavior (or Grinder rerun link):
Expected behavior
Tests pass
Screenshots
I've bundled these tests together as I they all utilise various scaffolding programs (JDI, Test and Shell) to set up the environment for the test.
Each of these are heavily dependant on the infrastructure of the machine that the test is running on and, as identified in #1711, there are some differences between versions and platforms that could cause the errors seen here. The purpose of this issue is to examine the scaffolding programs to see if there is something that is causing these failures and also to use as a placeholder for excluding these tests until they can be triaged appropriately.
Additional context
com/sun/jdi/PopAndStepTest.java
andcom/sun/jdi/PopSynchronousTest.java
andcom/sun/jdi/Redefine-g.sh
all have a very similar error. Its likely fixing the scaffold behind each of these tests (Test) will resolve all three failures.The text was updated successfully, but these errors were encountered: