Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FinalizeOverride Test runs despite being excluded #1852

Closed
adamfarley opened this issue Jun 26, 2020 · 5 comments
Closed

FinalizeOverride Test runs despite being excluded #1852

adamfarley opened this issue Jun 26, 2020 · 5 comments
Labels
Projects
Milestone

Comments

@adamfarley
Copy link
Contributor

adamfarley commented Jun 26, 2020

Describe the bug
FinalizeOverride is in the ProblemList exclude file for this release+jvm, but it is still being run.
See here for test run.
See here for the relevant problem list.

To Reproduce
Run nightly sanity.openjdk job like the one here:
https://ci.adoptopenjdk.net/job/Test_openjdk14_j9_sanity.openjdk_ppc64le_linux/123/

Expected behavior
This test is not meant to run at all.

Additional context
The test has been excluded for 2 days, and yet it is still being run.

@smlambert
Copy link
Contributor

Excluding the test, and then continuing to run the test in a separate target (jdk_lang_ref_FinalizeOverride_j9) with different options (see #1845) was purposefully done by @pshipton

We can repurpose this issue as jdk_lang_ref_FinalizeOverride_j9 fails issue, @pshipton we would normally exclude non-green tests, is this one intermittent and you are trying to gather data, or shall we also disable jdk_lang_ref_FinalizeOverride_j9 ?

@pshipton
Copy link
Contributor

It's a trade off. Although the test fails intermittently, it could still catch another real problem if it started failing more frequently or always. Although it shouldn't, excluding might have the side affect of de-prioritizing the work to fix it.

@sophia-guo
Copy link
Contributor

Maybe we could move it to special category? So it could run daily and not block the sanity?

@smlambert
Copy link
Contributor

good plan @sophia-guo - let's do that!

@karianna karianna added this to TODO in aqa-tests via automation Jun 29, 2020
@karianna karianna added the bug label Jun 29, 2020
@smlambert
Copy link
Contributor

Closing this as it is intended to continue to run the test and it has been moved to special.openjdk via #1863

aqa-tests automation moved this from TODO to Done Jul 15, 2020
@karianna karianna added this to the July 2020 milestone Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
aqa-tests
  
Done
Development

No branches or pull requests

5 participants