Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude tests #1733

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Exclude tests #1733

merged 3 commits into from
Apr 22, 2020

Conversation

M-Davies
Copy link
Contributor

@M-Davies M-Davies commented Apr 17, 2020 •
edited
Loading

Signed-off-by: Morgan Davies morgan.davies@ibm.com

Exclude tests on Windows
de7eabe 
* Follow up to adoptium#1719 and adoptium#1724 which did not successfully exclude the tests on x32
* Also escalates the exclusion of EvalArraysAsList.sh to all windows machines

Signed-off-by: Morgan Davies <morgan.davies@ibm.com>
@M-Davies M-Davies mentioned this pull request Apr 17, 2020
Closed
@M-Davies
Copy link
Contributor Author

@smlambert Does putting x32 as an ARCH work for the problemlists? These tests were excluded on x64 and x32 but they were still failing on the nightly runs

@karianna karianna added the bug label Apr 17, 2020
@karianna karianna added this to TODO in aqa-tests via automation Apr 17, 2020
@karianna karianna added this to the April 2020 milestone Apr 17, 2020
@karianna karianna moved this from TODO to In Progress in aqa-tests Apr 17, 2020
@karianna karianna requested a review from smlambert April 17, 2020 14:44
@M-Davies
Copy link
Contributor Author

Conflict resolved

@M-Davies
Copy link
Contributor Author

#1733 (comment)
For the record, this was resolved in slack https://adoptopenjdk.slack.com/archives/C5219G28G/p1587481964058800

@M-Davies M-Davies changed the title Exclude tests on Windows Exclude tests Apr 22, 2020
karianna
karianna approved these changes Apr 22, 2020
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@karianna karianna merged commit 9631e41 into adoptium:master Apr 22, 2020
aqa-tests automation moved this from In Progress to Done Apr 22, 2020
@M-Davies M-Davies deleted the exclude branch April 22, 2020 10:57
@M-Davies M-Davies mentioned this pull request Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@smlambert smlambert Awaiting requested review from smlambert

Assignees
No one assigned
Labels
bug
Projects
No open projects
aqa-tests
  
Done
Milestone
April 2020
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@M-Davies @karianna