Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thai: title audio and video when download is incorrect with generated link name #27

Open
cjrayance opened this issue Feb 24, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@cjrayance
Copy link

2023-02-24 16-52-36

But the subtitle file name is the same as the anime title with episode title.

aaa

@AdvMaple
Copy link
Owner

I don't see any issue here, can you give me an example of what you hoping for?

@cjrayance
Copy link
Author

in Generate link to download
subtitle : อภินิหารหุ่นทะลวงสวรรค์ บทที่ 1 - Bilibili
video : อภินิหารหุ่นทะลวงสวรรค์ บทที่ 1 - Bilibili
audio : อภินิหารหุ่นทะลวงสวรรค์ บทที่ 1 - Bilibili
(This is thai language , just see what's difference )

in .gif i posted you will see , when i click to save as in video tab => it generate filename n23055..... .MP4
but i want อภินิหารหุ่นทะลวงสวรรค์ บทที่ 1 - Bilibili.MP4 on filename

Do you understand me, sir ?

@cjrayance
Copy link
Author

but in subtitle tab when i click to save as => it gave me อภินิหารหุ่นทะลวงสวรรค์ บทที่ 1 - Bilibili.srt
not n23055bla bla bla.srt

@AdvMaple
Copy link
Owner

Oh, I see your problem now 🦆 I've to try so hard 🤣
Yes, but Thai, Chinese, etc is not my main language so I'll not prioritize fixing this. Mean while please endure this 😞 I will need to triangulate the problem to see if this is Window download/Chorme bug, or JS bug.

@AdvMaple AdvMaple added the bug Something isn't working label Mar 29, 2023
@AdvMaple AdvMaple changed the title title audio and video kinda wired ?? Thai: title audio and video when download is incorrect with generated link name Mar 29, 2023
@cjrayance
Copy link
Author

Thank you very much, sir

maybe because I use google translate, will make you misunderstand.

sorry for my english skill.

@calavikevin
Copy link
Contributor

This problem is really difficult to solve when you use 'save link as..." from the browser's context menu. At this time, the browser will use the filename from the url instead of the custom url that the plugin defines.

To handle this problem, the plugin needs to be able to download video content directly without having to use "save link ass...". I'm not sure if this problem can be solved or not, because it depends on whether the bilibili allows it or not (convert video/audio content to blob).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants