JS acf.findFields returns unrequested types in ACF6

[herrvigg]

The new Javascript API doesn't behave as expected with ACF6 (up to 6.0.5).

acf.findFields({type: 'text'})

When editing a field group, this returns other elements with data-type="tab" like this:

<div class="acf-field acf-field-tab acf-field-acf-field-group-settings-tabs"
     data-type="tab" data-key="acf_field_group_settings_tabs">

Expected result: only elements of data-type="text", not tab.

Looking at the value of the internal selector in findFields there have been some changes but we can see there's still a regression:

ACF 5.12.4 - OK
.acf-field[data-type="text"]:visible
ACF 6.0.3 - WRONG
.acf-field[data-type="text"]:visible,, .acf-field-acf-field-settings-tabs, .acf-field-acf-field-group-settings-tabs
ACF 6.0.5 - WRONG
.acf-field[data-type="text"]:visible,, .acf-field-acf-field-group-settings-tabs

By debugging the JS scripts I found the tabs are added by this find_fields_selector filter:

acf/assets/build/js/acf-input.js

Lines 5712 to 5714 in 366796a

	if (!args.suppressFilters) {
	selector = acf.applyFilters('find_fields_selector', selector, args);
	}

--> adds '.acf-field-acf-field-group-settings-tabs'

Why and where does it come from? I didn't set this filter, so it should not be a result of the user request.
It can be disabled by suppressFilters as a workaround but this field is not even documented. IMO it should not be set by the user to filter unexpected results. The default behavior should remain as in ACF5.

[mattgrshaw]

@herrvigg Thanks for the report.

This was done in order to add support for the tabs in the new UI that was introduced in 6.0, and these fields should only show up if acf.findFields() is called while in the field group editor.

However, I can see how this definitely isn't ideal (especially when checking for a specific field type as in your example), and have raised this with the team so we can look into improving this in a future release.