Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PW-6014] Missing refusalReasonCode and refusalReason from payment-status store API response #209

Closed
AndreasA opened this issue Sep 14, 2021 · 7 comments
Assignees

Comments

@AndreasA
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

See: https://github.com/Adyen/adyen-shopware6/blob/develop/src/Handlers/PaymentResponseHandler.php#L299

where for authorized, refused and errors, only the resultCode is provided but not refusal reason or code.

However, in order to provide the user with error codes related to the refusal reason, it is necessary to have this information in a PWA.

@peterojo peterojo changed the title Missing refusalReasonCode and refusalReason from payment-status store API response [PW-6041] Missing refusalReasonCode and refusalReason from payment-status store API response Dec 13, 2021
@peterojo peterojo self-assigned this Dec 13, 2021
@AndreasA
Copy link
Contributor Author

@peterojo just to let you know I recently did an upgrade on the headless project adyen is in use and except for a workaround for this fix, the default adyen implementation works there (except for the 3DS secure v1 redirect storefront is enabled on the sales channel, but that was more an issue with Shopware - might be fixed now but didn't test it).

@AndreasA
Copy link
Contributor Author

AndreasA commented Mar 9, 2022

@peterojo Any news regarding this ?

@peterojo
Copy link
Contributor

peterojo commented Mar 9, 2022

Hi @AndreasA this has been added in #236, pending the next release.

@AndreasA
Copy link
Contributor Author

AndreasA commented Mar 14, 2022

@peterojo One more question i noticed that some refusal codes like 22 with message FRAUD-CANCELLED is returned as Cancelled by Adyen itself instead of refused.

In this case with the change from #236 will not be shown as cancelled uses the default refusal code.

Also Authorised according to https://github.com/Adyen/adyen-shopware6/pull/236/files returns also refusal codes which seems wrong.

maybe move authorised outside and add canceled to the error/refused block ?

or is this hidden by desing?

@peterojo peterojo changed the title [PW-6041] Missing refusalReasonCode and refusalReason from payment-status store API response [PW-6014] Missing refusalReasonCode and refusalReason from payment-status store API response Mar 14, 2022
@RokPopov
Copy link
Contributor

Hey @AndreasA could you please try this PR -> #240 and see if it solves the issue for you?

@AndreasA
Copy link
Contributor Author

AndreasA commented Mar 14, 2022

@RokPopov I tested #240 with some refusal codes (22, 23, 25) and with it all refusal codes are forwarded to the store api and show the correct response.

So thanks. Of course, it also requires a release and merge first 😄

@RokPopov
Copy link
Contributor

Hi @AndreasA , thanks for the testing this and updating us. Happy to see the correct response is being shown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants