Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fn with_id #8

Closed
wants to merge 2 commits into from
Closed

Conversation

huang12zheng
Copy link

fix: test dependencies error with replace _ to -

if I just open workspace at tests. it get some error about loss config args about "workspace"

@huang12zheng huang12zheng mentioned this pull request Nov 3, 2022
@Aelto
Copy link
Owner

Aelto commented Nov 3, 2022

if I just open workspace at tests. it get some error about loss config args about "workspace"

Do not open the test workspace but instead open the whole project and run cargo test. Even if it were not to work, please revert the changes you commited to the cargo.toml and cargo lock files. These things have nothing to do with your PR.

Aelto added a commit that referenced this pull request Nov 8, 2022
@Aelto
Copy link
Owner

Aelto commented Nov 8, 2022

Due to the lack of activity, the fact there are still unwanted changes to the toml & lock cargo files and the simplicity of the changes i decided to skip the PR and implement the function myself.

Thanks for your contribution and suggestions

@Aelto Aelto closed this Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants