Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo doesn't appear back after scrolling back to top of the page #70

Closed
amichel86 opened this issue Jan 15, 2020 · 3 comments
Closed

Logo doesn't appear back after scrolling back to top of the page #70

amichel86 opened this issue Jan 15, 2020 · 3 comments

Comments

@amichel86
Copy link

amichel86 commented Jan 15, 2020

Hello and thanks for you plugin!

I noticed on Edge, when I scroll passed my first "midnight" section and come back to the top of the page, sometimes the logo doesn't appear. It is a strange bug that doesn't happen all the time. Would you happen to know a fix and or an alternative plugin?

It happens on your demo page on Edge too.

https://youtu.be/_TtlsxD8lTY

Thanks!

@amichel86 amichel86 changed the title Logo doesn't appear back after scrolling to first midnight section Logo doesn't appear back after scrolling to top of the page Jan 15, 2020
@amichel86 amichel86 changed the title Logo doesn't appear back after scrolling to top of the page Logo doesn't appear back after scrolling back to top of the page Jan 15, 2020
@RobertoGonzalez
Copy link
Member

RobertoGonzalez commented Jan 18, 2020

Hi @amichel86!
It seems it's a bug with Edge and multiple nested transforms (which we use to clip the different headers). From what I can tell, when the inner transform goes to 110%, some of the inner layers seem to get corrupted and they either become transparent or randomly show other parts of the site.

I'd take a stab in the dark and guess it's some sort of underlying GPU OOM issue with Edge, so if you really need this to work I'd try disabling transforms by forcing the _getSupportedTransform method to return false on Edge and seeing if that helps.

Since Edge has relatively few users and they are going to switch to Webkit soon I personally wouldn't worry too much about this bug, since their rendering engine is going to be phased out pretty soon.
If you can get it to work I'd be happy to accept a PR though.

@amichel86
Copy link
Author

@RobertoGonzalez I'm kind of a JS noob, can you explain a little further how I can have the _getSupportedTransform function return false on Edge? Thanks!

@RobertoGonzalez
Copy link
Member

@amichel86 Matching the browser's user agent to the MS Edge User Agent should work. I believe it's the Edg/ keyword you should look for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants