Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Online test suite fails when run in github actions #335

Open
oshoma opened this issue Apr 9, 2024 · 0 comments
Open

[BUG] Online test suite fails when run in github actions #335

oshoma opened this issue Apr 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@oshoma
Copy link
Collaborator

oshoma commented Apr 9, 2024

Describe the bug
The "Run Online Tests" github action fails when attempting to run tests.

To Reproduce
Steps to reproduce the behavior:

  1. Go to "Run Online Tests" github action
  2. Click on 'Run Workflow'
  3. Wait until action completes
  4. Look at action results to see many errors

See https://github.com/Aggregate-Intellect/sherpa/actions/runs/8607639155/job/23588508515 for an example.

Expected behavior
The action should run and complete successfully, running tests in online mode.

Additional Context

  1. This github action requires several secrets to be set within the repository settings, but as of April 8 I can't see any secrets set on github. This may be a source of trouble.
  2. Some of the secret names in the workflow file don't match what we expect in .ENV, e.g. ${{ secrets.SERPAAPIKEY }} should be SERPER_API_KEY. We should use the names expected in src/sherpa_ai/config/init.py
@oshoma oshoma added the bug Something isn't working label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants