Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-Story Node with multiple output handles #105

Merged
merged 17 commits into from May 9, 2022
Merged

User-Story Node with multiple output handles #105

merged 17 commits into from May 9, 2022

Conversation

Geissemanu
Copy link
Contributor

@Geissemanu Geissemanu commented Apr 28, 2022 •
edited

Related Issues

Definition of Done

  • User Story
    • All Acceptance Criteria met
  • Code
    • No more code needed
    • No known bugs
  • Clean Code
    • Comments have been created for new code
    • ESLinter found no issues (editor & executor only)
    • No unavoidable Code Smells
  • Testing
    • Existing Tests pass
    • New Unit Tests created
    • New Unit Tests pass
  • SonarCloud Quality Gate passed

Definition of more than Done (optional)

  • Testing
    • New Integration Tests created
    • New Integration Tests passed

@Geissemanu Geissemanu changed the title added test for multiple handles #81 User-Story Node with multiple output handles Apr 28, 2022
@Geissemanu Geissemanu self-assigned this May 5, 2022
@Geissemanu Geissemanu added the enhancement New feature or request label May 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

[API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

[Executor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Geissemanu
Copy link
Contributor Author

The changes in the Executor will wrap the results of every node in an Object. The Object contains a Field for every outgoingHandle and saves the result there. If in the Future Nodes with diferent Outputs will be created, they can be differenciated by the Outgoing Handle ID.

@Geissemanu Geissemanu marked this pull request as ready for review May 5, 2022 18:28
riesentoaster
riesentoaster requested changes May 5, 2022
View reviewed changes
Copy link
Contributor

@riesentoaster riesentoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some ideas/change suggestions.

src/executor/source/executor/nodes/HttpInputNode.ts Outdated Show resolved Hide resolved
src/executor/source/executor/nodes/ScriptNode.ts Show resolved Hide resolved
src/executor/source/executor/nodes/ScriptNode.ts Outdated
@@ -10,7 +10,7 @@ export interface ScriptNode {
*
* @param node to execute
* @param inputs of the node as an object, with the handle ids as the keys and the inputs as the values
* @returns the output of the JavaScript function
* @returns the output of the JavaScript function wraped into an object in fields of the outgoingHandle IDs
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: wrapped. Also: Call it inputs everywhere if there might be multiple inputs (check other files too please).

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[Identity] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[Editor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented May 9, 2022

[Executor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@Geissemanu Geissemanu merged commit db334a5 into main May 9, 2022
@riesentoaster riesentoaster deleted the user-story/node-multiple-output-handle branch May 9, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S4nvers S4nvers S4nvers approved these changes

@riesentoaster riesentoaster riesentoaster approved these changes

Assignees

@Geissemanu Geissemanu

Labels
enhancement New feature or request
Projects
Development V1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nodes with multiple output handles
3 participants
@Geissemanu @S4nvers @riesentoaster