Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add roles to identity #164

Merged
merged 9 commits into from Jun 2, 2022
Merged

Add roles to identity #164

merged 9 commits into from Jun 2, 2022

Conversation

DuplosFidibuss
Copy link
Contributor

@DuplosFidibuss DuplosFidibuss commented May 25, 2022 •
edited

Related Issues

Definition of Done

  • User Story
    • All Acceptance Criteria met
  • Code
    • No more code needed
    • No known bugs
  • Clean Code
    • Comments have been created for new code
    • ESLinter found no issues (editor & executor only)
    • No unavoidable Code Smells
  • Testing
    • Existing Tests pass
    • New Unit Tests created
    • New Unit Tests pass
  • SonarCloud Quality Gate passed

Service specific Definition of done

  • Api
    • New Integration Tests created
    • New Integration Tests passed
  • Editor (optional)
    • New End-to-End Tests created
    • New End-to-End Tests passed

The identity project is excluded from the test coverage since it is tested live, therefore neither unit tests nor integration tests need to be created for this PR.

@DuplosFidibuss DuplosFidibuss added api This issue is related to the API identity labels May 25, 2022
@DuplosFidibuss DuplosFidibuss self-assigned this May 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

[Identity] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

[Identity] Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

[API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

[Landing Page] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

[Executor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Jun 2, 2022

[Editor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DuplosFidibuss DuplosFidibuss merged commit f77fd12 into main Jun 2, 2022
@DuplosFidibuss DuplosFidibuss deleted the feature/identity-roles branch June 2, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrF3lix MrF3lix MrF3lix approved these changes

Assignees

@DuplosFidibuss DuplosFidibuss

Labels
api This issue is related to the API identity
Projects
Development V1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add roles (Free,Pro,God)
3 participants
@DuplosFidibuss @MrF3lix @riesentoaster