Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Story: Save linearized graph #85

Merged
merged 43 commits into from Apr 26, 2022
Merged

User Story: Save linearized graph #85

merged 43 commits into from Apr 26, 2022

Conversation

floomm
Copy link
Contributor

@floomm floomm commented Apr 14, 2022 •
edited by Geissemanu

Related Issues

Definition of Done

  • User Story (All Acceptance Criteria met):
    • The api should store a linearised version of the data flow
    • The executor should linearise the data flow only after a change
    • The executor should use the linearised version if it exists in the api
  • Code
    • No more code needed
    • No known bugs
  • Clean Code
    • Comments have been created for new code
    • ESLinter found no issues (editor & executor only)
    • SonarLint found no issues (API)
    • No unavoidable Code Smells
  • Testing
    • Existing Tests pass
    • New Unit Tests created
    • New Unit Tests pass
  • SonarCloud Quality Gate passed

Definition of more than Done (optional)

  • Testing
    • New Integration Tests created
    • New Integration Tests passed

@floomm floomm added api This issue is related to the API executor This issue is related to the executor labels Apr 14, 2022
@floomm floomm changed the title UC: Save linearized graph User Story: Save linearized graph Apr 17, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 17, 2022

[Editor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2022

[API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

86.6% 86.6% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 22, 2022

[Executor] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

58.6% 58.6% Coverage
0.0% 0.0% Duplication

DuplosFidibuss
DuplosFidibuss suggested changes Apr 23, 2022
View reviewed changes
Copy link
Contributor

@DuplosFidibuss DuplosFidibuss left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Would be good if another executor expert could have a look at this, too (especially the executor part, of course). @S4nvers could you do that?
And please mark it as ready to review (it is still a draft).

src/api/Flooq.IntegrationTest/LinearizedGraphTest.cs Show resolved Hide resolved
src/api/Flooq.Test/Controllers/LinearizedGraphControllerTest.cs Outdated Show resolved Hide resolved
src/api/Flooq.Test/Controllers/LinearizedGraphControllerTest.cs Show resolved Hide resolved
src/api/Flooq.Test/Services/LinearizedGraphServiceTest.cs Outdated Show resolved Hide resolved
@floomm floomm marked this pull request as ready for review April 24, 2022 10:00
S4nvers
S4nvers requested changes Apr 25, 2022
View reviewed changes
src/executor/source/executor/Linearization.ts Outdated Show resolved Hide resolved
src/executor/spec/executor/Linearization.spec.ts Outdated Show resolved Hide resolved
src/executor/spec/routes/DataflowRouter.spec.ts Outdated Show resolved Hide resolved
@floomm floomm mentioned this pull request Apr 25, 2022
Closed
2 tasks
@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

[Executor] Please retry analysis of this Pull-Request directly on SonarCloud.

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

[API] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

96.3% 96.3% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Apr 26, 2022

[Executor] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@floomm floomm merged commit 3ef82d7 into main Apr 26, 2022
@floomm floomm deleted the user-story/save-linearized-graph branch April 26, 2022 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S4nvers S4nvers S4nvers approved these changes

@DuplosFidibuss DuplosFidibuss DuplosFidibuss approved these changes

Assignees

@floomm floomm

@Geissemanu Geissemanu

Labels
api This issue is related to the API executor This issue is related to the executor
Projects
Development V1
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save linearised graph
4 participants
@floomm @S4nvers @DuplosFidibuss @Geissemanu