Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leptons render python wrapper code in UI instead of source code #697

Open
Emmanuel289 opened this issue Jun 21, 2022 · 7 comments
Open

Leptons render python wrapper code in UI instead of source code #697

Emmanuel289 opened this issue Jun 21, 2022 · 7 comments
Labels
bug Something isn't working hacktoberfest Part of Hacktoberfest Team Psi - BE Covalent Team Psi BE Team Psi Covalent Team Psi

Comments

@Emmanuel289
Copy link
Contributor

Environment

  • Covalent version: 0.110.0
  • Python version: 3.8.13
  • Operating system: Linux/MacOS

What is happening?

When dispatching Leptons, the python wrapper code gets rendered to the UI instead of the Lepton's source instead.

How can we reproduce the issue?

This can be reproduced by dispatching a task containing a lepton and observing its output in the UI. The python wrapper code gets rendered to the UI instead of the Lepton's source code.

What should happen?

A lepton's source code should be rendered in the UI and not its python wrapper.

Any suggestions?

No response

@Emmanuel289 Emmanuel289 added the bug Something isn't working label Jun 21, 2022
@santoshkumarradha santoshkumarradha added the good first issue Good for newcomers label Jun 21, 2022
@wjcunningham7 wjcunningham7 added the priority / high One of the top priorities in a week label Jul 27, 2022
@wjcunningham7
Copy link
Member

wjcunningham7 commented Jul 27, 2022

short term solution: do not show source code for C Leptons

@scottwn scottwn self-assigned this Aug 1, 2022
@scottwn scottwn added the Epic A group of issues forms an epic label Aug 1, 2022
@wjcunningham7 wjcunningham7 added hacktoberfest Part of Hacktoberfest and removed good first issue Good for newcomers priority / high One of the top priorities in a week Epic A group of issues forms an epic labels Sep 26, 2022
@wjcunningham7 wjcunningham7 added unitaryhack-bounty and removed hacktoberfest Part of Hacktoberfest labels May 24, 2023
@TerraVenil
Copy link

Hi, @Emmanuel289. Just to make sure that I understand expected result let's take a look an example, to be more concrete https://github.com/AgnostiqHQ/covalent/blob/develop/doc/source/how_to/coding/construct_lepton.ipynb. You would expect to see in this area instead of python_wrapper function
image
code from Python file, right?

def entrypoint(x: int, y: int) -> int:
    return x + y

@nrhawkins
Copy link

I was considering looking at this one; however, I am getting errors trying to install covalent. I am following the "First Steps" to contribute instructions at https://github.com/AgnostiqHQ/covalent/blob/master/CONTRIBUTING.md. I am getting an error in the third cell, after the command: python setup.py webapp

The error:
File ".../anaconda3/envs/cov_dev/lib/python3.8/subprocess.py", line 516, in run
raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['yarn', 'build']' returned non-zero exit status 1.

Any suggestions? Thanks!

@TerraVenil
Copy link

TerraVenil commented Jun 13, 2023

Hi @nrhawkins. Can you execute the following?

cd covalent_ui/webapp
yarm build

Probably you have an issue related to the node version. To setup webapp part there is another doc here https://github.com/AgnostiqHQ/covalent/blob/develop/covalent_ui/README.md or https://github.com/AgnostiqHQ/covalent/blob/master/CONTRIBUTING.md#contribution-for-covalent-ui

@nrhawkins
Copy link

Hi @TerraVenil - thanks so much!!! I hadn't read ahead, but I see there now that it requires node v16 or later. I had 12, which was the default for my latest Ubuntu and Fedora Linux. Looks like I am in business now!!! All the tests pass too. Thanks again!!! I guess the hack is over, but, at least, I feel better!

@wjcunningham7 wjcunningham7 added hacktoberfest Part of Hacktoberfest and removed unitaryhack-bounty labels Sep 23, 2023
@wjcunningham7
Copy link
Member

This issue is a part of Hacktoberfest. Closing this issue will earn you 3 points.

@ShatilKhan
Copy link

I'd like to earn 3 points please!

@santoshkumarradha santoshkumarradha added Team Psi Covalent Team Psi Team Psi - BE Covalent Team Psi BE labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Part of Hacktoberfest Team Psi - BE Covalent Team Psi BE Team Psi Covalent Team Psi
Projects
None yet
Development

No branches or pull requests

7 participants