Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrading to googlePlayServicesVersion 21.0.1 #424

Open
trne opened this issue Nov 6, 2023 · 2 comments
Open

upgrading to googlePlayServicesVersion 21.0.1 #424

trne opened this issue Nov 6, 2023 · 2 comments

Comments

@trne
Copy link

trne commented Nov 6, 2023

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch react-native-geolocation-service@5.3.1 for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-geolocation-service/android/build.gradle b/node_modules/react-native-geolocation-service/android/build.gradle
index cf167cf..47fd5ae 100644
--- a/node_modules/react-native-geolocation-service/android/build.gradle
+++ b/node_modules/react-native-geolocation-service/android/build.gradle
@@ -4,7 +4,7 @@ def DEFAULT_COMPILE_SDK_VERSION          = 29
 def DEFAULT_BUILD_TOOLS_VERSION          = "29.0.2"
 def DEFAULT_MIN_SDK_VERSION              = 16
 def DEFAULT_TARGET_SDK_VERSION           = 29
-def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "18.0.0"
+def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "21.0.1"
 
 def safeExtGet(prop, fallback) {
   rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback

This issue body was partially generated by patch-package.

@its-acarn
Copy link

Thanks @trne

This resolved an issue I was experiencing on Android for the error (see image)
bug

@LouisJS
Copy link

LouisJS commented Nov 24, 2023

Thank you guys ! I've had this issue and updating the versioning to

playServicesLocationVersion = "21.0.1"

in my build.gradle. It works. Along side with

googlePlayServicesVersion = "18.0.0"

I've also run

npx patch-package react-native-geolocation-service

after modifying

-def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "18.0.0"
+def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "21.0.1"

in node_modules/react-native-geolocation-service/android/build.gradle

I think there is a related PR waiting to be merged. So this might be fixed in near future i hope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants